-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update jackson, snakeyaml and docker-java versions #10258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jackson, snakeyaml and docker-java versions #10258
Conversation
codefish1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ive doubled checked, these are the latest versions as of today.
Thanks
|
@eddumelendez Can you enable the tests CI flows so we can confirm this does not break and review? |
The easiest way to run CI and get that feedback is to send a pull request to your own fork's main and let CI run I did that in my fork + your changes here: yeikel#1 Unfortunately, your changes are not passing some of the workflows ie: There are also other failures Refer to the link above to see the full CI Run. Example: https://github.com/yeikel/testcontainers-java/actions/runs/15290585561/job/43009689378?pr=1 I also sent you an invite in case it is more convenient to just push to my fork |
|
It seems that the issue is a mismatch as Although we may be able to overwrite that, it seems safer to upgrade |
|
Let me know when that version is published and I'll add it to the build |
@ZachChuba https://github.com/docker-java/docker-java/releases/tag/3.5.3 is published |
|
@ZachChuba I updated and tested the upgrade via yeikel#2. All the tests are passing now Can you merge that patch in? After that, we'll need help to get it reviewed |
|
@yeikel Pushed the changes, in this PR |
As per GitHub, your branch is not up to date with main. Can you resolve that? |
Code hygene and clearing falsely flagged CVEs
Also downgrade jackson to 2.18.4 to be aligned with docker-java-bom.
d0adb4a to
14deb03
Compare
|
Rebased |
|
Thank you so much for your contribution! |
|
Thanks everyone, I've been following keenly. Just need to wait for the release now, when do we think that would be |
@eddumelendez Thank you for the quick turnaround Given that what motivated this change was a CVE, is there any chance we can push this out as a minor patch? I noticed that it is part of the next milestone, but it is unclear what the criteria for the next release are. Thank you! |
|
@eddumelendez Same question as above, is there any information on when the next release that contains this change will be available? |
|
Hi, when is this going to be available in a release, please? Or is there some roadmap with planned future releases, please? |
|
Hi, same request as above. It would be really helpful for us to have this as a patch release |
|
Hi team, Sorry for the ping but we've been waiting since May is there anything we can do to help this move forward as a release? Thanks in advance! |
|
@yeikel @Rene2000k I've been waiting as well, v2.0.1 is now released and shows 0 vulns on sonatype. |
Yep, thank you. V2.0.0 is also not showing any vun for me |
Code hygene and clearing falsely flagged CVEs
Upgrade jackson and snakeyaml to the latest version. Aside from providing code hygene, these two dependencies are flagged by FOSS scanning tools as having critical severity CVEs. Although not exploitable in testcontainers, this causes a headache for developers.
This is to address Issue #9289