-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Cmake optimization with warp2 #4452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ble_adaptive_matcher to CLASSIFY_ENABLE_ADAPTIVE_MATCHER_OVERRIDE to avoid conflicts with the BOOL_MEMBER parameter declaration in classify.cpp
|
What is warp2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to put any code changes outside of this CMake PR.
|
macOS CMake CI failed without these non-CMake changes. This is reason why they are in this PR. |
|
Regarding warp see https://www.warp.dev/ |
|
What is the purpose of all this? Someone says GLOBs = bad? What about the rest? |
|
Could you fix the issue? |
|
@amitdo: this PR was merged on Aug 15 This issue seems specific to the combination of macOS, CMake, and GCC; other configurations such as macOS with CMake and Clang, or Ubuntu with CMake and GCC, do not show the problem.
I do not have access to a macOS device for debugging and testing this scenario. Additionally, I noticed that the autotools-macos uses only Clang as the compiler on macOS. Perhaps we should consider skipping GCC builds in the CMake workflow for macOS as well. |
|
Seems like it if fixed. |



Usage Examples