Skip to content

feat(webview): show VIN as a Tooltip on car name #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(webview): show VIN as a Tooltip on car name #4861

wants to merge 10 commits into from

Conversation

Helvio88
Copy link

image

@netlify Netlify
Copy link

netlify bot commented Jul 31, 2025 •
edited
Loading

✅ Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit 268ead6
🔍 Latest deploy log https://app.netlify.com/projects/teslamate/deploys/68af3b5a2970820008525467
😎 Deploy Preview https://deploy-preview-4861--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Helvio88
Copy link
Author

Feel free to squash commits to get rid of my back and forth attempts to do a clipboard copy :)
I couldn't figure out a test environment.

@JakobLichterfeld JakobLichterfeld added the area:teslamate Related to TeslaMate core label Aug 5, 2025
JakobLichterfeld
JakobLichterfeld requested changes Aug 5, 2025
View reviewed changes
Copy link
Member

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for your contribution!

I could see some users might want this addition.

Please update the test accordingly.

@JakobLichterfeld
Copy link
Member

Please also lint your code correctly: https://docs.teslamate.org/docs/development#code-formatting

@JakobLichterfeld JakobLichterfeld marked this pull request as draft August 5, 2025 16:39
@JakobLichterfeld JakobLichterfeld changed the title VIN as a Tooltip behing Car's Name feat(webview): show VIN as a Tooltip on car name Aug 5, 2025
@Helvio88 Helvio88 marked this pull request as ready for review August 26, 2025 20:40
@Helvio88
Copy link
Author

I believe I did what was needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobLichterfeld JakobLichterfeld JakobLichterfeld requested changes

Assignees
No one assigned
Labels
area:teslamate Related to TeslaMate core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Helvio88 @JakobLichterfeld