fix: treat tflint exit code 2 as failure #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The wrapper now treats tflint exit code 2 (issues found) as a failure. This aligns with tflint's behavior when using --minimum-failure-severity flag. Previously, exit code 2 was treated as success, which prevented the wrapper from properly respecting the --minimum-failure-severity flag introduced in tflint v0.45.0. Fixes #323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the wrapper to properly handle tflint exit codes. The wrapper was incorrectly treating exit code 2 as success.
Issue
tflint exits with code 2 when it finds issues that should cause failure (based on
--minimum-failure-severityif set, or any issues if not set). The wrapper was treating this as success, which is incorrect.Changes
Breaking Change
--minimum-failure-severity=error.Fixes #323