Skip to content

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Mar 19, 2025

  • Add new dns_allow_external_traffic bool to set control_plane_endpoints_config. dns_endpoint_config.allow_external_traffic

@apeabody apeabody force-pushed the ap/dns_endpoint branch 3 times, most recently from 34afb41 to 961a1eb Compare March 19, 2025 22:05
@apeabody apeabody marked this pull request as ready for review March 19, 2025 23:20
@apeabody apeabody requested review from ericyz and a team as code owners March 19, 2025 23:20
@apeabody apeabody requested a review from bharathkkb March 20, 2025 16:03
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Regarding breaking change, I think this should be since private cluster users will now need to set dns_allow_external_traffic explicitly instead of the previous gating condition. Could another option be to temporarily allow both old gating condition (var.enable_private_endpoint && var.deploy_using_private_endpoint) or new var and then in the next major release we can clean up the old gating condition?

@apeabody apeabody changed the title feat: add dns_allow_external_traffic feat!: add dns_allow_external_traffic Mar 21, 2025
@apeabody
Copy link
Collaborator Author

apeabody commented Mar 21, 2025

LGTM Regarding breaking change, I think this should be since private cluster users will now need to set dns_allow_external_traffic explicitly instead of the previous gating condition. Could another option be to temporarily allow both old gating condition (var.enable_private_endpoint && var.deploy_using_private_endpoint) or new var and then in the next major release we can clean up the old gating condition?

That a great idea - I'll rework to gate on either condition (for private clusters) for now. Thanks!

@apeabody apeabody changed the title feat!: add dns_allow_external_traffic feat: add dns_allow_external_traffic Mar 21, 2025
@apeabody apeabody force-pushed the ap/dns_endpoint branch 2 times, most recently from a47a9e0 to 7c244e9 Compare March 25, 2025 23:01
@apeabody apeabody merged commit 9124dbe into main Mar 27, 2025
8 checks passed
@apeabody apeabody deleted the ap/dns_endpoint branch March 27, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants