Small refactorings #174
Draft
Small refactorings #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoljungberg
force-pushed
the
small-refactorings
branch
2 times, most recently
from
0b604b6 to
15d311f
Compare
teoljungberg
force-pushed
the
small-refactorings
branch
2 times, most recently
from
dc807c7 to
f6ea29f
Compare
teoljungberg
force-pushed
the
small-refactorings
branch
from
f6ea29f to
433b504
Compare
The latter is deprecated since Ruby 2.4
Correct spelling in YARD documentation comments.
- Fix 'drop' to 'update' in update_trigger documentation - Fix 'function' to 'trigger' in trigger method documentation - Add missing type annotations for all parameters
- Add [void] return type for all database operation methods - Add proper return types for Configuration accessors
teoljungberg
force-pushed
the
small-refactorings
branch
from
9307ddc to
aa654fc
Compare
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the collection of refactorings produced after reviewing the
codebase, they will be merged as separate commits as I tried to keep
them self contained.
Some, or all, will be included. We will see. I am leaving this as a
placeholder.