Use the Java Op generator #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Collaborator
|
Ok so it passes a few platforms in the full build but timed out eventually and Bazel-caching is not enabled for PRs so we will now give it a shot in master. I did not went through all the 1000+ regenerated ops to find issues but we'll fix them as we find them, if any. Great work @rnett ! I might miss that old C++ code of mine but that is just me being sentimental :) |
Collaborator
Collaborator
|
@rnett , we've noticed that on Windows, looks like there are only 603 files being compiled while on Linux, there are 1807. If that can give some cue... |
Contributor
Author
|
Odd, that seems like it's probably a problem with the op export code rather than the op generation. Will look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the Java op generator during
installand removes the C++ generator. Builds fine locally, although there are still Javadoc errors in core with openjdk14 for non-opgen classes (i.e.scopeparam tags are used in theOpsclass). I'll leave them to another PR.@karllessard can you flag this for CI build?
It also fixes #286.