Fix memory leak occuring with new layout of string tensors #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
I've changed the base to r0.3 and it seems like it can still merge this, so go ahead! |
Also fix and actually use JavaCPP deallocator for TF_Session as well
karllessard
approved these changes
Mar 27, 2021
Collaborator
karllessard
left a comment
karllessard
left a comment
There was a problem hiding this comment.
All right looks good @saudet , thanks! I'll merge it when I'll be ready to release 0.3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix and actually use JavaCPP deallocator for TF_Session as well
Fixes #251 and we should probably add a regression test for that somewhere.
What would be a good place?