Boolean mask ops #214
Merged
Boolean mask ops #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
Signed-off-by: Ryan Nett <[email protected]>
rnett
force-pushed
the
rn_boolean_mask
branch
from
137b0d8 to
5597981
Compare
Contributor
Author
|
I can't run tests locally b/c |
karllessard
reviewed
Feb 23, 2021
| public Scope withNameAsSubScope(String defaultName){ | ||
| return new Scope(env, nameScope.withSubScope(nameScope.makeOpName(defaultName)), controlDependencies, deviceSpec); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
It could be interesting to update our other composite ops to make use of this new method, like this one:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom ops for boolean masking (
tensor[mask]andtensor[mask] = update).Note that there is no Python equivalent of
BooleanMaskUpdate, but there is in Numpy and PyTorch, so I included it.