Skip to content

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Aug 7, 2025

No description provided.

@kemingy kemingy requested a review from Copilot August 7, 2025 08:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves a cyclic import issue by moving the VechordPipeline class from vechord/pipeline.py to vechord/registry.py and updating all relevant imports and type annotations. The change breaks the circular dependency that existed between the registry and pipeline modules.

Key changes:

  • Moved VechordPipeline class definition from pipeline.py to registry.py
  • Updated imports in pipeline.py to remove circular dependency
  • Simplified the main module's __init__.py exports

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
vechord/registry.py Added VechordPipeline class definition and imported limit_to_transaction_buffer_conn
vechord/pipeline.py Removed VechordPipeline class and updated type annotations to use direct imports
vechord/init.py Simplified exports by removing most component imports while keeping core functionality
Comments suppressed due to low confidence (1)

vechord/pipeline.py:74

  • This logic assumes there are at least 2 steps in the pipeline. If there's only 1 step, self.steps[-1] on line 75 will execute the same function twice (once as steps[0] on line 72, then again as steps[-1]). Consider adding validation for minimum pipeline length.
class KeywordSearchOption(msgspec.Struct, kw_only=True):

Signed-off-by: Keming <[email protected]>
@kemingy kemingy merged commit 6b427b1 into tensorchord:main Aug 7, 2025
7 checks passed
@kemingy kemingy deleted the cycle_import branch August 7, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant