test: add e2e test for examples in documentations #804
Conversation
Signed-off-by: Jinjing.Zhou <[email protected]>
VoVAllen
requested review from
aseaday,
gaocegege,
kemingy and
zwpaper
as code owners
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
|
|
||
| up_tests := []string{"testdata/minimal", "testdata/getting_started", "testdata/jupyter", "testsdata/complex"} |
There was a problem hiding this comment.
Should we move everything to examples and then test things in that folder directly? Otherwise, we need to maintain the copies in this folder.
There was a problem hiding this comment.
It's for the examples on the documentation site. Therefore no duplication here I think
There was a problem hiding this comment.
I wonder if we can insert these envd files into the doc instead of copying them here.
There was a problem hiding this comment.
It would be great but may be hard to implement. I think copy/paste works in the current design.
There was a problem hiding this comment.
https://vitepress.vuejs.org/guide/markdown#import-code-snippets
Vitepress support this, but bit hard since they're not in the same repo
There was a problem hiding this comment.
Will open a new issue to track this.
Signed-off-by: Jinjing.Zhou <[email protected]>
Signed-off-by: Jinjing.Zhou <[email protected]>
Signed-off-by: Jinjing.Zhou <[email protected]>
VoVAllen
changed the title
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
|
|
||
| up_tests := []string{"testdata/minimal", "testdata/getting_started", "testdata/jupyter", "testsdata/complex"} |
There was a problem hiding this comment.
I wonder if we can insert these envd files into the doc instead of copying them here.
|
Please ping me if it is ready to review. |
Signed-off-by: Jinjing.Zhou <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VoVAllen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jinjing.Zhou <[email protected]>
|
@gaocegege PTAL |
4 participants
Signed-off-by: Jinjing.Zhou [email protected]