Skip to content

refactor(builder): Abstract BuildFunc to use gateway client #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2022
Merged

refactor(builder): Abstract BuildFunc to use gateway client #606

merged 5 commits into from
Jul 15, 2022

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jul 14, 2022 •
edited
Loading

Ref #194

Signed-off-by: Ce Gao [email protected]

aseaday
aseaday approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@aseaday aseaday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://discordapp.com/channels/974584200327991326/985401618277228604/997065620166295572

@gaocegege
fix: Fix test cases
3d2931b 
Signed-off-by: Ce Gao <[email protected]>
@gaocegege gaocegege requested review from VoVAllen and kemingy July 14, 2022 10:05
VoVAllen
VoVAllen approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there any material about buildkit frontend gateway?

@aseaday
Copy link
Member

aseaday commented Jul 14, 2022

LGTM. Is there any material about buildkit frontend gateway?
https://github.com/moby/buildkit#building-a-dockerfile-using-external-frontend
IMO it is just custom frontend build image.

@gaocegege
Copy link
Member Author

LGTM. Is there any material about buildkit frontend gateway?

#194 (comment)

@gaocegege gaocegege merged commit 18abe90 into tensorchord:main Jul 15, 2022
@gaocegege gaocegege deleted the build branch July 15, 2022 01:27
@gaocegege gaocegege mentioned this pull request Jul 15, 2022
Open
@gaocegege gaocegege changed the title feat(builder): Abstract BuildFunc to use gateway client refactor(builder): Abstract BuildFunc to use gateway client Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aseaday aseaday aseaday approved these changes

@VoVAllen VoVAllen VoVAllen approved these changes

@kemingy kemingy kemingy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
envd sprint board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gaocegege @aseaday @VoVAllen @kemingy