Skip to content

chore: Improve error wrapping and checking #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

chore: Improve error wrapping and checking #590

merged 1 commit into from
Jul 12, 2022

Conversation

terrytangyuan
Copy link
Member

This fixes the following error lint checks:

comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error
type assertion on error will fail on wrapped errors. Use errors.As to check for specific errors

Signed-off-by: Yuan Tang [email protected]

gaocegege
gaocegege approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaocegege gaocegege merged commit a84af3a into tensorchord:main Jul 12, 2022
@terrytangyuan terrytangyuan deleted the error-wrap branch July 12, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaocegege gaocegege gaocegege approved these changes

Assignees

No one assigned

Labels

None yet

Projects

No open projects
envd sprint board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terrytangyuan @gaocegege