Skip to content

chore: update envd destroy cmd log msg #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2022
Merged

chore: update envd destroy cmd log msg #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/app/destroy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var CommandDestroy = &cli.Command{
},
&cli.PathFlag{
Name: "name",
Usage: "Name of the environment",
Usage: "Name of the environment or container ID",
Aliases: []string{"n"},
},
},
Expand Down
4 changes: 2 additions & 2 deletions pkg/docker/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,8 @@ func (c generalClient) Destroy(ctx context.Context, name string) (string, error)
// If the container is not running, there is no need to kill it.
logger.Debug("container is not running, there is no need to kill it")
case strings.Contains(errCause, "No such container"):
// If the container is not found, it is already destroyed.
logger.Debug("container is not found, there is no need to destroy it")
// If the container is not found, it is already destroyed or the name is wrong.
logger.Infof("cannot find container %s, maybe it's already destroyed or the name is wrong", name)
return "", nil
default:
return "", errors.Wrap(err, "failed to kill the container")
Expand Down