Skip to content

feat(CLI): Add push #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 1, 2022
Merged

feat(CLI): Add push #531

merged 4 commits into from
Jul 1, 2022

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jun 30, 2022 •
edited
Loading

Fix #201

Ref #510

   To build an image using build.envd:
     $ envd build
   To build and push the image to a registry:
     $ envd build --output type=image,name=docker.io/username/image,push=true

Signed-off-by: Ce Gao [email protected]

@gaocegege gaocegege requested review from VoVAllen and rudeigerc June 30, 2022 08:53
@gaocegege gaocegege changed the title feat(CLI): Add push WIP feat(CLI): Add push Jun 30, 2022
rudeigerc
rudeigerc approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@rudeigerc rudeigerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

By the way, it would be better for us to explain the available keys of --output, or refer to the documentation of buildkit.

@gaocegege
Copy link
Member Author

Yep, I think we can document it.

@gaocegege
Copy link
Member Author

https://coveralls.io/github/tensorchord/envd coveralls got server down.

Let's wait

VoVAllen
VoVAllen reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

pkg/builder/util.go

// Example: type=tar,dest=path
matched, err := regexp.Match(`^type=[\s\S]+,dest=[\s\S]+$`, []byte(output))
e, err := parseOutputCSV(exports)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's csv for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output type=tar,image=imagename,push=true is CSV-format.

@VoVAllen
Copy link
Member

Also this didn't solve #510, right?

@gaocegege
Copy link
Member Author

Also this didn't solve #510, right?

We need to discuss it with users to decide if it works.

After the PR, you can push the image in GitHub actions.

@gaocegege gaocegege merged commit 8276d7d into tensorchord:main Jul 1, 2022
@gaocegege gaocegege deleted the push branch July 1, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VoVAllen VoVAllen VoVAllen approved these changes

+1 more reviewer

@rudeigerc rudeigerc rudeigerc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

No open projects
envd sprint board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(CLI): Support push command

3 participants

@gaocegege @VoVAllen @rudeigerc