-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add CHASM Visibility registration and task processing #8491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
8d45ce3
Add CHASM Visibility registration and task processing
awln-temporal dd5301f
Remove unused code
awln-temporal bf50c0a
simplify search attribute constructor methods
awln-temporal 358a354
Update linters
awln-temporal c103f5f
Update implementation to use separate mapper and search attribute pro…
awln-temporal 100cdce
Remove unused code for the RegistrableComponent
awln-temporal cad4f71
Remove unused variable name ref
awln-temporal 34b9c4a
Add compile time checks for the mapper interface
awln-temporal cc8a8b0
Rename SetValue to ValueSet
awln-temporal e928a2d
revert visibility queue task executor
awln-temporal 6ee5c7f
Move attribute to global variable
awln-temporal c3ae24b
Change search attribute index constructors to constant refs
awln-temporal 6cbbf09
Move mapper provider to RegistrableComponent
awln-temporal c7df243
Add panic check in component registration
awln-temporal 92d5c4a
Add upsert memo method
awln-temporal aebc387
Move validation to registration call
awln-temporal dacfea5
Change search attribute provider interface to list of SearchAttribute…
awln-temporal bd03919
Move exported search attribute field constants to top of file
awln-temporal 4bdd20c
address accessor comments
awln-temporal 438f71a
Refactor conversion of []SearchAttributeKeyValue to shared map
awln-temporal fd7f41d
Add error return type for mapper provider interface
awln-temporal cfccb46
Change accessor level of predefined CHASM search attribute constructor
awln-temporal bb107ff
Add compile time type checks
awln-temporal 10e9e45
Change acceessor back to public to fix unit tests
awln-temporal cd1339f
Update chasm search attribute documentation and mapper interface
awln-temporal f7d4eb2
Fix linter issue
awln-temporal 5c46ffc
Shorten field name resolution
awln-temporal fdc9951
Amend test search attribute accessor level
awln-temporal 7f9c611
Fix linter issues
awln-temporal 528ada8
Address PR comments
awln-temporal 3a14adc
Move validation to component instantiation
awln-temporal b52cdd4
Rename method names
awln-temporal d66929a
Merge branch 'main' into CHASMSearchAttributeComponents
awln-temporal 4182664
Add functional tests for CHASM search attributes
awln-temporal 561c911
Fix unit test expectations
awln-temporal d482d91
Address remaining comments
awln-temporal f8aea8b
Update TODO message
awln-temporal 99328af
Update library search attributes option
awln-temporal f5eb991
Update panic message format chasm/registrable_component.go
awln-temporal 7c936e3
Update panic message format chasm/registrable_component.go
awln-temporal 6d683fe
Update invalid argument message chasm/visibility.go
awln-temporal 3501cb5
Update invalid argument message chasm/visibility.go
awln-temporal 05d9d12
Address PR comments
awln-temporal b55c253
Merge branch 'main' into CHASMSearchAttributeComponents
awln-temporal d25f0dc
Add predefined search attributes
awln-temporal 6269b51
Update error message chasm/visibility.go
awln-temporal 0d1575a
Update error message
awln-temporal 27658af
Merge branch 'main' into CHASMSearchAttributeComponents
awln-temporal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use one attribute that is an alias to an existing pre-defined field for completeness? I feel like you're not understanding what I'm asking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apologies, there was a reference to use a "predefined" field (not TemporalInt01 etc) in test_component_test.go. I also added a reference to the predefined field
SearchAttributeTemporalScheduledByID.As for whether to include it in Payload.go, there was a previous TODO to track
CountandSizeas search attributes, and I wasn't sure that adding a reference toTemporalScheduledByIdmade sense within the scope of the Payload component. This component only tracks the current count and size of payloads, and a map from the PayloadKey to its Payload blob. What would be the values provided to the search attribute?I agree that functional tests should cover this case, I just wasn't sure if it was acceptable style to add a search attribute that doesn't seem related to the component. Added a reference in payload.go to this.