Skip to content

Conversation

@yuandrew
Copy link
Contributor

@yuandrew yuandrew commented Apr 29, 2025

What was changed

Created a new Github Action that auto-generates and publishes a PR to the documentation repo with the latest generated CLI docs.

Corresponding docs side PR is already merged, temporalio/documentation#3525, and first PR of the auto-generated docs is merged in temporalio/documentation#3528.

Docs side YML: https://github.com/temporalio/documentation/blob/main/.github/workflows/update-cli-docs.yml

Why?

Makes keeping CLI docs up to date significantly easier.

Checklist

  1. Closes

  2. How was this tested:

Tested in this PR, but there's a small chance I missed something in the actual release trigger workflow. No way to fully test that until a new release is cut after this action is on main.

  1. Any docs updates needed?

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking

env:
GITHUB_TOKEN: ${{ steps.generate_token.outputs.token }}
run: |
gh workflow run update-cli-docs.yml \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to the PR with this workflow in it on the docs side? Just curious. I am happy to see we are delegating the generation to that workflow instead of trying to do it here and shipping data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry you asked for the PR, that should already be in the PR desc, temporalio/documentation#3525

Copy link
Member

@cretz cretz Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All LGTM.

@yuandrew yuandrew merged commit 46a13e8 into main Apr 30, 2025
9 checks passed
@yuandrew yuandrew deleted the auto-publish-pr-docs1 branch April 30, 2025 17:13
yuandrew added a commit that referenced this pull request Jul 8, 2025
## What was changed
<!-- Describe what has changed in this PR -->
Target `main` branch instead of the dev branch I was using when working
on the feature

## Why?
<!-- Tell your future self why have you made these changes -->
Fixing a bug from #796 

## Checklist
<!--- add/delete as needed --->

1. Closes <!-- add issue number here -->

2. How was this tested:
<!--- Please describe how you tested your changes/how we can test them
-->
Untested, this path triggers on release, should be fine to wait for next
release to ensure it's fixed. Not the worst case if this pipeline misses
a release

3. Any docs updates needed?
<!--- update README if applicable
      or point out where to update docs.temporal.io -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants