Skip to content

tests: pdate csi-node-driver-registrar image reference #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

tests: pdate csi-node-driver-registrar image reference #9089

merged 1 commit into from
Oct 21, 2025

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 21, 2025

Changes

Seems like the quay.io image is either gone, or at least sometimes
gone. The repository for this is
https://github.com/kubernetes-csi/node-driver-registrar, the image
referenced there is from k8s.gcr.io, so let's use it.

Signed-off-by: Vincent Demeester [email protected]

/kind flake

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/flake Categorizes issue or PR as related to a flakey test labels Oct 21, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2025
twoGiants
twoGiants approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@twoGiants twoGiants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/meow

@tekton-robot
Copy link
Collaborator

tekton-robot commented Oct 21, 2025

@twoGiants: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@vdemeester vdemeester added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@vdemeester vdemeester closed this Oct 21, 2025
@vdemeester vdemeester reopened this Oct 21, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Tekton Community Roadmap Oct 21, 2025
@vdemeester
tests: pdate csi-node-driver-registrar image reference
68ca8f3 
Seems like the quay.io image is either gone, or at least sometimes
gone. The repository for this is
https://github.com/kubernetes-csi/node-driver-registrar, the image
referenced there is from k8s.gcr.io, so let's use it.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the fix-spire-agent-csi-node-image branch from f19d67f to 68ca8f3 Compare October 21, 2025 11:16
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Oct 21, 2025

New changes are detected. LGTM label has been removed.

@vdemeester
Copy link
Member Author

vdemeester commented Oct 21, 2025

hmm EasyCLA checks is not happy with this pull-request, I am not sure why... 🤔

@vdemeester
Copy link
Member Author

vdemeester commented Oct 21, 2025

/easy-cla

aThorp96
aThorp96 approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@aThorp96 aThorp96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgmt

@tekton-robot
Copy link
Collaborator

tekton-robot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: aThorp96, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member Author

vdemeester commented Oct 21, 2025

/easycla

@vdemeester
Copy link
Member Author

vdemeester commented Oct 21, 2025

😭

@vdemeester
Copy link
Member Author

vdemeester commented Oct 21, 2025

/easycla

@vdemeester vdemeester added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@tekton-robot tekton-robot merged commit 6f880cc into tektoncd:main Oct 21, 2025
44 of 46 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tekton Community Roadmap Oct 21, 2025
@vdemeester vdemeester deleted the fix-spire-agent-csi-node-image branch October 21, 2025 12:45
@aThorp96 aThorp96 mentioned this pull request Nov 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

@jerop jerop Awaiting requested review from jerop

2 more reviewers

@twoGiants twoGiants twoGiants approved these changes

@aThorp96 aThorp96 aThorp96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@twoGiants twoGiants

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flakey test lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vdemeester @tekton-robot @twoGiants @aThorp96