Skip to content

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 8, 2025

Changes

From 1.28 to 1.33. Not that 1.34 is already available, so we could use it as well.

This also updates the image versions and digests.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Oct 8, 2025
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 8, 2025
@vdemeester vdemeester added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 8, 2025
@afrittoli
Copy link
Member

It's a bit weird to test 1.28 but not 1.29, but the matrix is getting too large which also means flakes are more likely to show and we're more likely to start hitting some rate limiting somewhere.
Perhaps we could have full test (stable, alpha, beta) on the latest 3 releases and stable only before that, but cover all releases between latest and the min supported? Or we could increase the min supported to 1.29.

Comment on lines 92 to 96
v1.29.x)
K8S_VERSION="1.29.14"
KIND_IMAGE_SHA="sha256:8703bd94ee24e51b778d5556ae310c6c0fa67d761fae6379c8e0bb480e6fea29"
KIND_IMAGE="kindest/node:${K8S_VERSION}@${KIND_IMAGE_SHA}"
;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.29 is not on the list of tested releases anymore (although it would be nice if it was

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what I did was, I got the latest of each version from their respective releases. 1.29 image still works but is not updated anymore by kind essentially. So I got the last one released.

@waveywaves
Copy link
Member

/retest

@vdemeester
Copy link
Member Author

It's a bit weird to test 1.28 but not 1.29, but the matrix is getting too large which also means flakes are more likely to show and we're more likely to start hitting some rate limiting somewhere. Perhaps we could have full test (stable, alpha, beta) on the latest 3 releases and stable only before that, but cover all releases between latest and the min supported? Or we could increase the min supported to 1.29.

Yes, I think we can run stable on all, but alpha, and beta only on the latest and the oldest or something even.

@vdemeester
Copy link
Member Author

Let me try something on this.

@vdemeester vdemeester force-pushed the e2e-update-k8s-versions branch 3 times, most recently from cfa1545 to efd06af Compare October 8, 2025 13:44
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2025
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the env files is not really important :P
Reducing the matrix sounds good to me.
Does testing alpha and beta on the oldest gives us more confidence for the other versions?

/approve

Comment on lines 48 to 56
- k8s-name: k8s-oldest
k8s-version: v1.28.x
feature-flags: stable
- k8s-name: k8s-oldest
k8s-version: v1.28.x
feature-flags: beta
- k8s-name: k8s-oldest
k8s-version: v1.28.x
feature-flags: alpha
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why testing stable, beta and alpha on oldest?

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@afrittoli
Copy link
Member

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2025
@afrittoli
Copy link
Member

I was too quick in approving. The k8s version ends up in the context now, which breaks the configuration of required jobs in prow. Is there any way around that?

@vdemeester
Copy link
Member Author

Does testing alpha and beta on the oldest gives us more confidence for the other versions?

I am not sure 😬 I thought having it on the latest and oldest is better than just having it on latest.

@vdemeester
Copy link
Member Author

I was too quick in approving. The k8s version ends up in the context now, which breaks the configuration of required jobs in prow. Is there any way around that?

Ah right, I didn't think of that... Instead of using include, we could use exclude with they way it was setup before. It would probably work, let me try that.
(for what is worth it doesn't seem to be blocking required jobs here, as there is no pending jobs, but not sure why..)

@vdemeester vdemeester force-pushed the e2e-update-k8s-versions branch from efd06af to 7071e2c Compare October 8, 2025 14:03
@vdemeester
Copy link
Member Author

Yeah, this works.

2025-10-08-160528

@afrittoli
Copy link
Member

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2025
From 1.28 to 1.33. Not that 1.34 is already available, so we could use
it as well. This also update images versions and digests.

In addition, it changes a bit how the matrix is set and only runs beta
and alpha tests on latest and oldest versions.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the e2e-update-k8s-versions branch from 36b75d4 to 9ccb3d7 Compare October 8, 2025 14:17
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@twoGiants
Copy link
Member

/lgtm
/meow

@tekton-robot
Copy link
Collaborator

@twoGiants: cat image

In response to this:

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2025
@tekton-robot tekton-robot merged commit f0d1e2a into tektoncd:main Oct 9, 2025
84 of 88 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Oct 9, 2025
@vdemeester vdemeester deleted the e2e-update-k8s-versions branch October 9, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants