-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test/e2e: update kubernetes versions we test against #9068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e: update kubernetes versions we test against #9068
Conversation
|
It's a bit weird to test 1.28 but not 1.29, but the matrix is getting too large which also means flakes are more likely to show and we're more likely to start hitting some rate limiting somewhere. |
hack/setup-kind.sh
Outdated
| v1.29.x) | ||
| K8S_VERSION="1.29.14" | ||
| KIND_IMAGE_SHA="sha256:8703bd94ee24e51b778d5556ae310c6c0fa67d761fae6379c8e0bb480e6fea29" | ||
| KIND_IMAGE="kindest/node:${K8S_VERSION}@${KIND_IMAGE_SHA}" | ||
| ;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.29 is not on the list of tested releases anymore (although it would be nice if it was
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what I did was, I got the latest of each version from their respective releases. 1.29 image still works but is not updated anymore by kind essentially. So I got the last one released.
|
/retest |
Yes, I think we can run stable on all, but alpha, and beta only on the latest and the oldest or something even. |
|
Let me try something on this. |
cfa1545 to
efd06af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the env files is not really important :P
Reducing the matrix sounds good to me.
Does testing alpha and beta on the oldest gives us more confidence for the other versions?
/approve
.github/workflows/e2e-matrix.yml
Outdated
| - k8s-name: k8s-oldest | ||
| k8s-version: v1.28.x | ||
| feature-flags: stable | ||
| - k8s-name: k8s-oldest | ||
| k8s-version: v1.28.x | ||
| feature-flags: beta | ||
| - k8s-name: k8s-oldest | ||
| k8s-version: v1.28.x | ||
| feature-flags: alpha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why testing stable, beta and alpha on oldest?
|
/hold |
|
I was too quick in approving. The k8s version ends up in the context now, which breaks the configuration of required jobs in prow. Is there any way around that? |
I am not sure 😬 I thought having it on the latest and oldest is better than just having it on latest. |
Ah right, I didn't think of that... Instead of using |
efd06af to
7071e2c
Compare
|
/hold cancel |
From 1.28 to 1.33. Not that 1.34 is already available, so we could use it as well. This also update images versions and digests. In addition, it changes a bit how the matrix is set and only runs beta and alpha tests on latest and oldest versions. Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
36b75d4 to
9ccb3d7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |


Changes
From 1.28 to 1.33. Not that 1.34 is already available, so we could use it as well.
This also updates the image versions and digests.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes