Move ConfigMap helpers to testing framework and cleanup 🧹 pipelinerun_test.go 🧹.
#8920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `ConfigMap` helper functions and constants to testing framework in `pkg/reconciler/testing/configmap.go`. Add convinience wrappers for repeating ConfigMap helper function combinations to reduce duplications. Remove unused constants and functions and inline variables to reduce the amount of local variables in `pipelinerun_test.go`. Issue tektoncd#8906. Signed-off-by: Stanislav Jakuschevskij <[email protected]>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/L
Member
Author
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
vdemeester
approved these changes
Jul 28, 2025
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move
ConfigMaphelper functions and constants to testing framework inpkg/reconciler/testing/configmap.go. Add convinience wrappers for repeating ConfigMap helper function combinations to reduce duplications.Remove unused constants and functions and inline variables to reduce the amount of local variables in
pipelinerun_test.go.Issue #8906.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes