Stop emitting deprecated metrics

[khrm]

This commit removes the following deprecated metrics that have been replaced with corresponding metrics.
We have given sufficient time to user to migrate to newer metrics.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

BREAKING CHANGE:

This commit removes the following deprecated metrics that have been replaced
by newer, more descriptive metrics:

PipelineRun Metrics:
- pipelinerun_count → replaced by pipelinerun_total
- running_pipelineruns_count → replaced by running_pipelineruns  
- running_pipelineruns_waiting_on_pipeline_resolution_count → replaced by running_pipelineruns_waiting_on_pipeline_resolution
- running_pipelineruns_waiting_on_task_resolution_count → replaced by running_pipelineruns_waiting_on_task_resolution

TaskRun Metrics:
- taskrun_count → replaced by taskrun_total
- running_taskruns_count → replaced by running_taskruns
- running_taskruns_throttled_by_quota_count → replaced by running_taskruns_throttled_by_quota
- running_taskruns_throttled_by_node_count → replaced by running_taskruns_throttled_by_node

The replacement metrics provide the same functionality with improved naming
conventions and are already being recorded in the codebase.

[khrm]

/kind misc

[khrm]

We already had an older PR which was approved and LGTM here: #8301, but it couldn't be merged due to rebase issue.

We should try to close this one.

[khrm]

/assign @vdemeester @waveywaves

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	87.4%	86.7%	-0.7
pkg/taskrunmetrics/metrics.go	88.1%	87.3%	-0.8

[khrm]

/retest

[khrm]

/retest ci / e2e-tests

Is workflow retest command working?

[tekton-robot]

@khrm: No presubmit jobs available for tektoncd/pipeline@main

In response to this:

/retest ci / e2e-tests

Is workflow retest command working?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	87.4%	86.7%	-0.7
pkg/taskrunmetrics/metrics.go	88.1%	87.3%	-0.8

[khrm]

It seems there are failure in e2e due to some other issues not related to PR.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	87.4%	86.7%	-0.7
pkg/taskrunmetrics/metrics.go	88.1%	87.3%	-0.8

[khrm]

/retest

[khrm]

/assign @afrittoli @vdemeester

Let's merge this. It was already approved and lgtm here: #8301

It couldn't be merged due to some rebase issue and I forgot to take a look. I would raise another PR to update our metrics to us OTEL via Knative.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	87.4%	86.7%	-0.7
pkg/taskrunmetrics/metrics.go	88.1%	87.3%	-0.8

[vdemeester]

/approve
/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment