Skip to content

Conversation

@khrm
Copy link
Contributor

@khrm khrm commented Jul 6, 2025

Before this, metrics were beign registered and unregisterd even when anything in configMap used to change including revision, etc. This causes gap in the metrics and gives us incorrect data over a long time if configmap revision changes.

Assisted-by: Gemini for unit testing

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 6, 2025
@tekton-robot tekton-robot requested review from afrittoli and dibyom July 6, 2025 22:56
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 6, 2025
@khrm
Copy link
Contributor Author

khrm commented Jul 6, 2025

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 6, 2025
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm
Copy link
Contributor Author

khrm commented Jul 6, 2025

There was already an old PR from me on this. Instead of necro-bumping that, I recreated a new one.
https://github.com/tektoncd/pipeline/pull/8241/files

There's also a bug related to this. Will search and try to link.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/metrics.go 86.5% 87.4% 0.9
pkg/taskrunmetrics/metrics.go 87.0% 88.1% 1.1

@khrm
Copy link
Contributor Author

khrm commented Jul 7, 2025

Fixes an old issue here: #7902

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
Before this, metrics were beign registered and unregisterd even
when anything in configMap used to change including revision, etc.
This causes gap in the metrics and gives us incorrect data over a
long time if configmap revision changes.

Assisted-by: Gemini for unit testing
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pipelinerunmetrics/metrics.go 86.5% 87.4% 0.9
pkg/taskrunmetrics/metrics.go 87.0% 88.1% 1.1

@khrm
Copy link
Contributor Author

khrm commented Jul 7, 2025

@waveywaves @afrittoli Can we get this merged?

@afrittoli afrittoli changed the title Re-register metrics only during real updation Re-register metrics only during real update Jul 7, 2025
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@tekton-robot tekton-robot merged commit 496efb9 into tektoncd:main Jul 7, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants