-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Re-register metrics only during real update #8863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/kind bug |
khrm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @vdemeester @waveywaves
|
There was already an old PR from me on this. Instead of necro-bumping that, I recreated a new one. There's also a bug related to this. Will search and try to link. |
|
The following is the coverage report on the affected files.
|
|
Fixes an old issue here: #7902 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before this, metrics were beign registered and unregisterd even when anything in configMap used to change including revision, etc. This causes gap in the metrics and gives us incorrect data over a long time if configmap revision changes. Assisted-by: Gemini for unit testing
|
The following is the coverage report on the affected files.
|
|
@waveywaves @afrittoli Can we get this merged? |
afrittoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
Before this, metrics were beign registered and unregisterd even when anything in configMap used to change including revision, etc. This causes gap in the metrics and gives us incorrect data over a long time if configmap revision changes.
Assisted-by: Gemini for unit testing
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes