Skip to content

Resolvers: remove default TEKTON_HUB_API URI #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

Resolvers: remove default TEKTON_HUB_API URI #8861

merged 1 commit into from
Jul 22, 2025

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Jul 3, 2025 •
edited
Loading

Changes

With the hub deprecation and up-coming shutdown of the hub.tekton.dev instance, we should stop having a default value for the TEKTON_HUB_API uri.

This doesn't stop users to use their own instance of the tektoncd/hub with the resolver.

/kind cleanup
/cc @afrittoli

Closes #8858

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Removing the default value of `TEKTON_HUB_API` in the resolvers deployment as the public instance of tektoncd/hub (hub.tekton.dev) will be shutdown in September. It's still possible to set this environment variable to a value for users who self host an instance of tektoncd/hub

@tekton-robot tekton-robot requested a review from afrittoli July 3, 2025 12:50
@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 3, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2025
@vdemeester
Copy link
Member Author

vdemeester commented Jul 3, 2025

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

tekton-robot commented Jul 3, 2025

@vdemeester: No presubmit jobs available for tektoncd/pipeline@main

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester vdemeester added this to the v1.3.0 (LTS) milestone Jul 4, 2025
@vdemeester
Copy link
Member Author

vdemeester commented Jul 16, 2025

cc @abayer @twoGiants @waveywaves

afrittoli
afrittoli reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2025
afrittoli
afrittoli reviewed Jul 16, 2025
View reviewed changes
twoGiants
twoGiants approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@twoGiants twoGiants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Approved!

@vdemeester
Resolvers: remove default TEKTON_HUB_API URI
a62565b 
With the hub deprecation and up-coming shutdown of the hub.tekton.dev
instance, we should stop having a default value for the TEKTON_HUB_API
uri.

This doesn't stop users to use their own instance of the tektoncd/hub
with the resolver.

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester force-pushed the remove-default-hub-api branch from b5004ab to a62565b Compare July 18, 2025 13:36
@twoGiants
Copy link
Member

twoGiants commented Jul 22, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2025
@twoGiants
Copy link
Member

twoGiants commented Jul 22, 2025

/meow

@tekton-robot
Copy link
Collaborator

tekton-robot commented Jul 22, 2025

@twoGiants: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@twoGiants
Copy link
Member

twoGiants commented Jul 22, 2025

/approve

@tekton-robot tekton-robot merged commit e7fe024 into tektoncd:main Jul 22, 2025
18 checks passed
@tekton-robot
Copy link
Collaborator

tekton-robot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester vdemeester deleted the remove-default-hub-api branch July 22, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afrittoli afrittoli afrittoli left review comments

+1 more reviewer

@twoGiants twoGiants twoGiants approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@twoGiants twoGiants

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

v1.3.0 (LTS)

Development

Successfully merging this pull request may close these issues.

Remove the default TEKTON_HUB_API in resolvers

4 participants

@vdemeester @tekton-robot @twoGiants @afrittoli