fix: Remove direct usage of testify from pkg/spire/

[infernus01]

Changes

This PR removes direct usage of github.com/stretchr/testify (see issue #8775). All assertions have been replaced with standard testing.T error handling methods.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Removed direct dependency on testify in pkg/spire to simplify testing and reduce external dependencies.

[infernus01]

/cc @vdemeester

[waveywaves]

/kind chore

[tekton-robot]

@waveywaves: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

In response to this:

/kind chore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[waveywaves]

/kind cleanup

[waveywaves]

/ok-to-test

[waveywaves]

/retest

[vdemeester]

Can we run rm -fR vendor && go mod tidy && go mod vendor to check if it removes the testify packages ?

[waveywaves]

@infernus01 please follow the commit message standards for this one and format the commit title and description accordingly

[infernus01]

@infernus01 please follow the commit message standards for this one and format the commit title and description accordingly

@waveywaves Got it! Next time, my commit messages will be so proper they'll wear a tie.

[infernus01]

Can we run rm -fR vendor && go mod tidy && go mod vendor to check if it removes the testify packages ?

@vdemeester yes after running these commands, I verified this removes the testify packages from pkg/spire directory.

[vdemeester]

@infernus01 ah it becomes an indirect dependency. If you run the oneline, it should modify go.mod, can you commit that change ?

[infernus01]

Edit: Per discussion with @aThorp96 and @waveywaves , I'm reverting the changes made here to the previous commit only.

so I removed the strechr testify package indirect dependency from one more place (check last commit) but as the following go mod why output suggests, it's being used in other places as well.

Here's the go mod why output:

# github.com/stretchr/testify
github.com/tektoncd/pipeline/cmd/resolvers
k8s.io/client-go/rest
k8s.io/client-go/rest.test
github.com/stretchr/testify/assert

/cc @vdemeester

[infernus01]

/retest

[waveywaves]

/retest

[waveywaves]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester,waveywaves]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment