Fix CRD Generation Errors

[tricktron]

Changes

Follows up on #8490 and fixes all the controller-gen warnings. Now all crds can be generated with the following command without any errors:

controller-gen crd:generateEmbeddedObjectMeta=false paths=./pkg/apis/pipeline/... output:dir=./crds

The main changes are:

• Remove the duplicated // +listType=atomic annotation from struct fields where the annotation is already set on the type.
• Create a type alias and set the list type annotation there (mainly with []corev1.Volume.
• Set the storagversion annotation to the most stable version.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tricktron / name: tricktron (2c9a667)

[tricktron]

/kind cleanup

[tricktron]

/assign @pritidesai

[tricktron]

@burigolucas and @vdemeester any inputs from your side?

[vdemeester]

@tricktron thanks for the PR. Seems like it doesn't compile.

 # github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1
Error: pkg/apis/pipeline/v1beta1/taskrun_conversion.go:266:13: rr.ConvertTo undefined (type TaskRunReason has no field or method ConvertTo)
Error: pkg/apis/pipeline/v1beta1/taskrun_conversion.go:319:49: cannot use new (variable of type TaskRunStatus) as TaskRunReason value in argument to append
Error: pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go:2601:10: cannot use make([]TaskRunStatus, len(*in)) (value of type []TaskRunStatus) as RetriesStatus value in assignment
Error: pkg/apis/pipeline/v1beta1/zz_generated.deepcopy.go:2603:13: (*in)[i].DeepCopyInto undefined (type TaskRunReason has no field or method DeepCopyInto)

[tricktron]

@vdemeester I fixed the compile error.

[tricktron]

@vdemeester I fixed the error in the hack/verify-codegen.sh ci job.

[afrittoli]

/approve

[afrittoli]

Thanks @tricktron - since type definitions are slightly different, you need to re-run the code generation script

[tricktron]

@afrittoli, Thanks for the headsup. I added the new files with are generated with ./hack/update-codegen.sh.

[burigolucas]

Thanks for this PR @tricktron Now that these changes solve the warnings, do we still get response code non zero from controller-gen? The warnings were braking the execution of update-schemas.sh. If we now only get response code 0, I would suggest that we remove the redirect in

pipeline/hack/update-schemas.sh

Line 58 in c23b9a9

paths=$API_PATH/$API_SUBDIR/... > $LOG_FILE 2>&1

[tricktron]

Thanks for this PR @tricktron Now that these changes solve the warnings, do we still get response code non zero from controller-gen? The warnings were braking the execution of update-schemas.sh. If we now only get response code 0, I would suggest that we remove the redirect in

pipeline/hack/update-schemas.sh

Line 58 in c23b9a9

paths=$API_PATH/$API_SUBDIR/... > $LOG_FILE 2>&1

@burigolucas Good point. Can´t we just replace this whole script with the following command:

go run sigs.k8s.io/controller-tools/cmd/[email protected] crd:generateEmbeddedObjectMeta=false output:dir=./config/300-crds paths=./pkg/apis/...

[burigolucas]

Thanks for this PR @tricktron Now that these changes solve the warnings, do we still get response code non zero from controller-gen? The warnings were braking the execution of update-schemas.sh. If we now only get response code 0, I would suggest that we remove the redirect in

pipeline/hack/update-schemas.sh

Line 58 in c23b9a9

paths=$API_PATH/$API_SUBDIR/... > $LOG_FILE 2>&1

@burigolucas Good point. Can´t we just replace this whole script with the following command:

go run sigs.k8s.io/controller-tools/cmd/[email protected] crd:generateEmbeddedObjectMeta=false output:dir=./config/300-crds paths=./pkg/apis/...

It won't work because the path depends on the API group. The script handles that. What I hope we can do is to get rid off the while loop, assuming there are no warnings returning status code 1 anymore. Please, see the FIXME comment on line 53 about it. The script will be much more clean without the while loop with the retries.

[waveywaves]

/ok-to-test

[tricktron]

@burigolucas I refactored and simplfied the hack/update-schemas.sh script. Have a look 😃.

[tricktron]

@burigolucas I tried to simplify the hack/update-schemas.sh file but now I am hitting the go panic describe here: kubernetes-sigs/controller-tools#627.

It seems that your while loop somehow protects against this. I have no idea why. Do you?

[tricktron]

@burigolucas Alright, I figured it out. Tekton diverges from the recommended one Go package per group/version kind and uses multiple Go packages per group/version which breaks controller-gen. As a result, we need to generate each CRD in isolation with the correct API package path. I fixed the hack/update-schemas.sh file and added a comment explaining this workaround.

Now all checks in the CI should pass. Could someone retrigger the CI to check?

[waveywaves]

@tricktron can you squash the commits into one and update the commit with a proper commit message, that would be done, after that I can approve it ✅

[tricktron]

@waveywaves Sure, I squashed everything into one commit and reworded the commit message.

[waveywaves]

cc @vdemeester

[tricktron]

@vdemeester @waveywaves kind ping.

[waveywaves]

/retest

[tricktron]

@vdemeester @waveywaves Kind reminder to have another look at this😃.

[vdemeester]

👼🏼

[waveywaves]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [afrittoli,vdemeester,waveywaves]
• pkg/apis/OWNERS [afrittoli,vdemeester,waveywaves]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment