[FIX] Remove the apt warning

[leshikus]

Changes

The apt manpage recommends against using it in scripts and issues a warning. This patch fixes the warning.

It also adds an option to debug ci worlflow via workflow_dispatch, and removes yamllint exception by properly formatting the on clause.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: leshikus / name: Alexei Fedotov (8525235, c284adb, 084554f)
• ✅ login: waveywaves / name: Vibhav Bobade (59647df)

[leshikus]

/kind cleanup

[leshikus]

@pritidesai how can I make progress with this PR?

[afrittoli]

Thank you for your contribution!
The change to apt-get looks good to me, but I'm not sure about adding the workflow_dispatch option here.

[afrittoli]

For testing the yamllint job, I would prefer if we added a yamllint target to the Makefile and use make yamllint in the workflow here, although the apt-get part would be trick in the Makefile as it would work only on debian based systems. @vdemeester wdyt?

[vdemeester]

I agree, I went for the quickest but indeed I agree with you. We may want to split this into an « install yamllint » action and a make yamllint 😇

[leshikus]

Thanks for your comments, will make yamlint available for local testing.

As for workflow_dispatch, it is needed to run tests in my fork before I submit a PR. There is another request for this feature #8621

[leshikus]

Let me know if you want me remove workflow_dispatch - due to some security or other reason

[vdemeester]

@leshikus let's remove the workflow_dispatch for now then 🙃

[leshikus]

@vdemeester @afrittoli , can we progress with this patch? I was thinking about spending some time working on this project and resolving more serious issues in future.

[vdemeester]

LGTM
cc @afrittoli @waveywaves

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[leshikus]

I wonder how can this PR get this LGTM label

[vdemeester]

@leshikus can you take care of my last comment, and I'll LGTM 👼🏼 😉

[waveywaves]

@leshikus I have updated the PR with the required change on your behalf hope that is ok, this is so that we can fast-forward this PR :)

cc @vdemeester

[leshikus]

@waveywaves thanks! sorry for missing the previous request

[waveywaves]

/lgtm ing based on Vincent's last comment 🚀