Skip to content

[release-v0.56.x] Use io.ReadFull to read the bundle content #8393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[release-v0.56.x] Use io.ReadFull to read the bundle content #8393

wants to merge 1 commit into from

Conversation

tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #8389

/assign vdemeester

Fix an issue on `bundle list` command with relatively big bundles that couldn't be parsed (truncated data)

@vdemeester
Use io.ReadFull to read the bundle content
1580452 
The io.Reader documentation says:

> Read reads up to len(p) bytes into p. It returns the number of bytes
> read (0 <= n <= len(p)) and any error encountered. ... If some data is
> available but not len(p) bytes, Read conventionally returns what is
> available instead of waiting for more.

Read is not guaranteed to fill the data argument. Use io.ReadFull to
fill the buffer.

In some cases (a relatively big bundle), the bundle content was not
completely read and it would fail to parse. Using `io.ReadFull` fixes
the issue.

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot mentioned this pull request Nov 18, 2024
Merged
8 tasks
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 18, 2024
@vdemeester
Copy link
Member

/kind bug
/approve
/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. kind/bug Categorizes issue or PR as related to a bug. labels Nov 18, 2024
@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@vdemeester
Copy link
Member

/retest

🤔 🤔 🤔

@tekton-robot
Copy link
Collaborator Author

@tekton-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-integration-tests 1580452 link true /test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-unit-tests 1580452 link true /test pull-tekton-pipeline-unit-tests
pull-tekton-pipeline-build-tests 1580452 link true /test pull-tekton-pipeline-build-tests
pull-tekton-pipeline-alpha-integration-tests 1580452 link true /test pull-tekton-pipeline-alpha-integration-tests
pull-tekton-pipeline-beta-integration-tests 1580452 link true /test pull-tekton-pipeline-beta-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vdemeester vdemeester closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vdemeester vdemeester

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tekton-robot @vdemeester