Implement set-security-context feature for affinity assistant containers #8182

kristofferchr · 2024-08-06T09:58:23Z

Needed for this issue: #8183

Changes

Added container securityContext for affinity assistant when feature flag set-security-context is set to true.
Implemented for both windows and linux OS. )

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
pre-commit Passed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Affinity Assistant containers will now have a securityContext when feature flag `set-security-context` is enabled in ConfigMap `feature-flags`.

tekton-robot · 2024-08-06T09:58:33Z

Hi @kristofferchr. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kristofferchr · 2024-08-06T09:58:33Z

/kind feature

tekton-robot · 2024-08-06T10:12:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

tekton-robot · 2024-08-06T10:52:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

pkg/reconciler/pipelinerun/affinity_assistant.go

pkg/reconciler/pipelinerun/affinity_assistant_test.go

kristofferchr · 2024-08-07T07:32:23Z

@vdemeester is this /ok-to-test ?

tekton-robot · 2024-08-07T07:41:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

chitrangpatel · 2024-08-07T14:07:51Z

/ok-to-test

tekton-robot · 2024-08-07T14:20:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

vdemeester · 2024-08-07T15:28:23Z

/retest

chitrangpatel · 2024-08-22T14:58:43Z

/lgtm

tekton-robot · 2024-08-22T20:32:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

tekton-robot · 2024-08-22T20:34:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

kristofferchr · 2024-08-23T11:17:12Z

@chitrangpatel this needs a new lgtm, had to rebase.

vdemeester

/lgtm

tekton-robot · 2024-08-29T12:18:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Ensures that when using Affinity Assistant, one can adhere to restricted pod security standards. Enables users to apply a container level securityContext for Affinity Assistants.

tekton-robot · 2024-08-30T09:44:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

tekton-robot · 2024-08-30T09:48:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

tekton-robot · 2024-08-30T09:50:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

kristofferchr · 2024-08-30T10:49:28Z

/test pull-tekton-pipeline-integration-tests

kristofferchr · 2024-08-30T10:49:52Z

/test pull-tekton-pipeline-beta-integration-tests

kristofferchr · 2024-09-01T20:37:20Z

/test pull-tekton-pipeline-go-coverage-df

tekton-robot · 2024-09-01T20:37:35Z

@kristofferchr: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-beta-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kristofferchr · 2024-09-01T20:45:00Z

@vdemeester need another /lgtm rebase changes again.

tekton-robot · 2024-09-01T20:50:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/affinity_assistant.go	96.9%	97.0%	0.1

vdemeester · 2024-09-18T09:36:31Z

/lgtm

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2024

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 6, 2024

tekton-robot requested review from abayer and afrittoli August 6, 2024 09:58

kristofferchr force-pushed the 5-set-container-level-securitycontext-for-affinity-assistant branch from d78fc27 to 8c3d09f Compare August 6, 2024 10:41

vdemeester approved these changes Aug 6, 2024

View reviewed changes

pkg/reconciler/pipelinerun/affinity_assistant.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/affinity_assistant_test.go Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024

kristofferchr force-pushed the 5-set-container-level-securitycontext-for-affinity-assistant branch from 8c3d09f to d7d9791 Compare August 7, 2024 07:27

kristofferchr mentioned this pull request Aug 7, 2024

Add feature flag set-security-context-read-only-root-filesystem to set readOnlyRootFilesystem for containers #8186

Merged

8 tasks

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2024

tekton-robot assigned chitrangpatel Aug 22, 2024

tekton-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 22, 2024

kristofferchr force-pushed the 5-set-container-level-securitycontext-for-affinity-assistant branch from d7d9791 to 1c07e21 Compare August 22, 2024 20:21

tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 22, 2024

vdemeester approved these changes Aug 29, 2024

View reviewed changes

tekton-robot assigned vdemeester Aug 29, 2024

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2024

kristofferchr force-pushed the 5-set-container-level-securitycontext-for-affinity-assistant branch from 1c07e21 to 2f787ae Compare August 30, 2024 09:34

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2024

Implement set-security-context feature for affinity assistant containers

3173496

Ensures that when using Affinity Assistant, one can adhere to restricted pod security standards. Enables users to apply a container level securityContext for Affinity Assistants.

kristofferchr force-pushed the 5-set-container-level-securitycontext-for-affinity-assistant branch from 2f787ae to 3173496 Compare August 30, 2024 09:37

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024

tekton-robot merged commit 0649270 into tektoncd:main Sep 18, 2024
1 check passed

kristofferchr deleted the 5-set-container-level-securitycontext-for-affinity-assistant branch September 18, 2024 11:01

Implement set-security-context feature for affinity assistant containers #8182

Implement set-security-context feature for affinity assistant containers #8182

Uh oh!

Conversation

kristofferchr commented Aug 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Aug 6, 2024

Uh oh!

kristofferchr commented Aug 6, 2024

Uh oh!

tekton-robot commented Aug 6, 2024

Uh oh!

tekton-robot commented Aug 6, 2024

Uh oh!

Uh oh!

Uh oh!

kristofferchr commented Aug 7, 2024

Uh oh!

tekton-robot commented Aug 7, 2024

Uh oh!

chitrangpatel commented Aug 7, 2024

Uh oh!

tekton-robot commented Aug 7, 2024

Uh oh!

vdemeester commented Aug 7, 2024

Uh oh!

chitrangpatel commented Aug 22, 2024

Uh oh!

tekton-robot commented Aug 22, 2024

Uh oh!

tekton-robot commented Aug 22, 2024

Uh oh!

kristofferchr commented Aug 23, 2024

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

tekton-robot commented Aug 29, 2024

Uh oh!

tekton-robot commented Aug 30, 2024

Uh oh!

tekton-robot commented Aug 30, 2024

Uh oh!

tekton-robot commented Aug 30, 2024

Uh oh!

kristofferchr commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kristofferchr commented Aug 30, 2024

Uh oh!

kristofferchr commented Sep 1, 2024

Uh oh!

tekton-robot commented Sep 1, 2024

Uh oh!

kristofferchr commented Sep 1, 2024

Uh oh!

tekton-robot commented Sep 1, 2024

Uh oh!

vdemeester commented Sep 18, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kristofferchr commented Aug 6, 2024 •

edited

Loading

kristofferchr commented Aug 30, 2024 •

edited

Loading