Replace PipelineRunReasonFailedValidation with more granular reasons #7417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/cleanup
tekton-robot
added
the
size/M
tekton-robot
added
the
do-not-merge/work-in-progress
JeromeJu
changed the title
vdemeester
approved these changes
Nov 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
part of #7434 |
JeromeJu
force-pushed
the
error-sweep-invalid-pipelineresult
branch
from
dbd2acd to
2387dd4
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
This commit adds the PipelineRunReasonCouldntGetPipelineResult which was previously conflated in PipelineRunReasonFailedValidation. It is now separated in order to keep the PipelineRunStatus failure reason granular. /kind cleanup
JeromeJu
force-pushed
the
error-sweep-invalid-pipelineresult
branch
from
2387dd4 to
5df6250
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add InvalidPipelineResult PipelineRunReason
This commit adds the PipelineRunReasonInvalidPipelineResult which was
previously conflated in PipelineRunReasonFailedValidation. It is now
separated in order to keep the PipelineRunStatus failure reason
granular.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes