TEP-0090: Matrix - Consume Results #5063

jerop · 2022-06-30T17:10:08Z

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

In this change, we implement consuming Results in a Matrix. This was disallowed in previous iterations of Matrix - validation failed.

With this change, Matrix supports Results of type String. Results of type Array are not yet available at the Pipeline level - this will be handled when it's available.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Docs included if any changes are user facing
Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

`Matrix` supports Results of type String.

jerop · 2022-06-30T17:11:30Z

cc @abayer @dibyom @lbernick please take a look

jerop · 2022-06-30T17:13:28Z

/kind feature

/retest

jerop · 2022-06-30T17:39:00Z

/test pull-tekton-pipeline-go-coverage

tekton-robot · 2022-06-30T17:39:03Z

@jerop: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test stage-tekton-pipeline-unit-tests

In response to this:

/test pull-tekton-pipeline-go-coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2022-06-30T18:17:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	97.9%	97.9%	-0.0

abayer · 2022-06-30T19:21:29Z

/retest

abayer · 2022-06-30T19:21:38Z

/test pull-tekton-pipeline-go-coverage

abayer · 2022-06-30T19:23:04Z

/approve

tekton-robot · 2022-06-30T19:27:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	97.9%	97.9%	-0.0

docs/matrix.md

pkg/apis/pipeline/v1beta1/param_types.go

pkg/reconciler/pipelinerun/pipelinerun_test.go

jerop · 2022-07-01T19:54:03Z

to clarify for reviewers, this change is implementing consuming results in a matrix - https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md#specifying-results-in-the-matrix

producing results from fanned out pipelinetasks is out of scope for tep-0090 (waiting for tep-0075 & tep-0075) - https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md#results-from-fanned-out-pipelinetasks

[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. In this change, we implement consuming `Results` in a `Matrix`. This was disallowed in previous iterations of `Matrix` - validation failed. With this change, `Matrix` supports Results of type String that are passed in individually. `Results` of type Array are not yet available at the `Pipeline` level - this will be handled when it's available. [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md

tekton-robot · 2022-07-01T20:41:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abayer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2022-07-01T20:46:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/param_types.go	97.9%	97.9%	-0.0

lbernick

/lgtm

jerop · 2022-07-01T21:14:18Z

/test pull-pipeline-kind-k8s-v1-21-e2e

tekton-robot · 2022-07-01T21:14:21Z

@jerop: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-pipeline-kind-k8s-v1-21-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerop · 2022-07-01T21:16:25Z

/test pull-tekton-pipeline-alpha-integration-tests

tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 30, 2022

tekton-robot requested review from abayer and imjasonh June 30, 2022 17:10

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 30, 2022

tekton-robot requested a review from dibyom June 30, 2022 17:10

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 30, 2022

lbernick reviewed Jul 1, 2022

View reviewed changes

docs/matrix.md Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1beta1/param_types.go Show resolved Hide resolved

pkg/reconciler/pipelinerun/pipelinerun_test.go Show resolved Hide resolved

jerop force-pushed the tep-0090-consume-results branch from 002c650 to c2c6c86 Compare July 1, 2022 20:41

tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 1, 2022

lbernick reviewed Jul 1, 2022

View reviewed changes

tekton-robot assigned lbernick Jul 1, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022

tekton-robot merged commit c7af1d4 into tektoncd:main Jul 1, 2022

TEP-0090: Matrix - Consume Results #5063

TEP-0090: Matrix - Consume Results #5063

Uh oh!

Conversation

jerop commented Jun 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

jerop commented Jun 30, 2022

Uh oh!

jerop commented Jun 30, 2022

Uh oh!

jerop commented Jun 30, 2022

Uh oh!

tekton-robot commented Jun 30, 2022

Uh oh!

tekton-robot commented Jun 30, 2022

Uh oh!

abayer commented Jun 30, 2022

Uh oh!

abayer commented Jun 30, 2022

Uh oh!

abayer commented Jun 30, 2022

Uh oh!

tekton-robot commented Jun 30, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jerop commented Jul 1, 2022

Uh oh!

tekton-robot commented Jul 1, 2022

Uh oh!

tekton-robot commented Jul 1, 2022

Uh oh!

lbernick left a comment

Choose a reason for hiding this comment

Uh oh!

jerop commented Jul 1, 2022

Uh oh!

tekton-robot commented Jul 1, 2022

Uh oh!

jerop commented Jul 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jerop commented Jun 30, 2022 •

edited

Loading