TEP-0090: Matrix - Minimal Status is Required #5019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
|
/lgtm |
|
Related PR: tektoncd/community#736 |
|
The following is the coverage report on the affected files.
|
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in parallel `TaskRuns` and `Runs` with substitutions from combinations of `Parameters` in a `Matrix`. The status of `PipelineRuns` with fanned-out `PipelineTasks` will list all the `TaskRuns` and `Runs` created. In [TEP-0100][tep-0100] we proposed changes to `PipelineRun` status to reduce the amount of information stored about the status of `TaskRuns` and `Runs` to improve performance, reduce memory bloat and improve extensibility. With the minimal `PipelineRun` status, we can handle `Matrix` without exacerbating the performance and storage issues that were there before. In this change, we validate that minimal embedded status is enabled when a `PipelineTask` has a `Matrix`. [tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md [tep-0100]: https://github.com/tektoncd/community/blob/main/teps/0100-embedded-taskruns-and-runs-status-in-pipelineruns.md
jerop
force-pushed
the
tep-0090-minimal-required
branch
from
d6c142d to
5d388a1
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
dibyom
approved these changes
Jun 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/kind feature |
tekton-robot
added
the
kind/feature
4 tasks
tekton-robot
pushed a commit
that referenced
this pull request
Jun 24, 2022
In tektoncd/community#736, we decided that `Matrix` will use `ChildReferences` only. Therefore, it is unnecessary to check the `TaskRuns` field of `PipelineRun` status when getting the names of `TaskRuns` for matrixed `PipelineTasks`. Related PR: #5019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TEP-0090: Matrix proposed executing a
PipelineTaskinparallel
TaskRunsandRunswith substitutions from combinationsof
Parametersin aMatrix.The status of
PipelineRunswith fanned-outPipelineTaskswilllist all the
TaskRunsandRunscreated.In TEP-0100 we proposed changes to
PipelineRunstatusto reduce the amount of information stored about the status of
TaskRunsandRunsto improve performance, reduce memory bloatand improve extensibility. With the minimal
PipelineRunstatus,we can handle
Matrixwithout exacerbating the performance andstorage issues that were there before.
In this change, we validate that minimal embedded status is enabled
when a
PipelineTaskhas aMatrix.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes