TEP-0090: Sort slice of TaskRunNames in tests
#4969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/S
lbernick
approved these changes
Jun 10, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
pritidesai
reviewed
Jun 10, 2022
`GetNamesOfTaskRuns` returns a slice of the names of `TaskRuns` and the order is not guaranteed - this causes issues with cmp.diff that makes the tests flakey. In this change, we sort the slice of `TaskRunNames` so that they can be compared in tests. In this change, we also rename related function names and variables for clarify.
|
thank you @jerop 👍 /lgtm |
jerop
changed the title
TaskRunNames in testsTaskRunNames in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GetNamesOfTaskRunsreturns a slice of the names ofTaskRunsand the order is not guaranteed - this causes issues with cmp.diff that makes the tests flakey.In this change, we sort the slice of
TaskRunNamesso that they can be compared in tests.In this change, we also rename related function names and variables for clarify.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes