Skip to content

TEP-0090: Get Names of TaskRuns #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

TEP-0090: Get Names of TaskRuns #4958

merged 1 commit into from
Jun 10, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 9, 2022 •
edited
Loading

Changes

TEP-0090: Matrix proposed executing a PipelineTask in parallel TaskRuns and Runs with substitutions from combinations of Parameters in a Matrix.

In this change, we add a function to get TaskRuns names from TaskRuns Status or Child References. If none are available, it generates new TaskRun names based on the PipelineRun and PipelineTask names.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 9, 2022
@tekton-robot tekton-robot requested review from dibyom and pritidesai June 9, 2022 22:29
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 93.7% 94.2% 0.5

pritidesai
pritidesai reviewed Jun 9, 2022
View reviewed changes
pritidesai
pritidesai reviewed Jun 9, 2022
View reviewed changes
@jerop jerop force-pushed the tep-0090-gettaskrunnames branch 2 times, most recently from f46adac to 0e401b2 Compare June 9, 2022 23:37
@jerop jerop changed the title TEP-0090: Get TaskRuns Names TEP-0090: Get Names of TaskRuns Jun 9, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 93.7% 94.2% 0.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 93.7% 94.2% 0.5

pritidesai
pritidesai reviewed Jun 9, 2022
View reviewed changes
@jerop jerop force-pushed the tep-0090-gettaskrunnames branch from 0e401b2 to 9433180 Compare June 10, 2022 00:15
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 93.7% 94.2% 0.5

pritidesai
pritidesai reviewed Jun 10, 2022
View reviewed changes
pritidesai
pritidesai approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @jerop 🎉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@jerop
TEP-0090: Get Names of TaskRuns
9e87a9e 
[TEP-0090: Matrix][tep-0090] proposed executing a `PipelineTask` in
parallel `TaskRuns` and `Runs` with substitutions from combinations
of `Parameters` in a `Matrix`.

In this change, we add a function to get names of `TaskRuns` from
`TaskRuns` Status or Child References. If none are available, it
generates new `TaskRun` names based on the `PipelineRun` and
`PipelineTask` names.

[tep-0090]: https://github.com/tektoncd/community/blob/main/teps/0090-matrix.md
@jerop jerop force-pushed the tep-0090-gettaskrunnames branch from 9433180 to 9e87a9e Compare June 10, 2022 11:58
@jerop
Copy link
Member Author

jerop commented Jun 10, 2022

@abayer @dibyom @lbernick - please take a look

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 93.7% 94.1% 0.5

@jerop
Copy link
Member Author

jerop commented Jun 10, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Jun 10, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2022
@tekton-robot tekton-robot merged commit 793c4c5 into tektoncd:main Jun 10, 2022
@jerop jerop deleted the tep-0090-gettaskrunnames branch June 11, 2022 01:40
This was referenced Jun 24, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pritidesai pritidesai pritidesai approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@abayer abayer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerop @tekton-robot @abayer @pritidesai