tekton: remove build-base-image from pipeline #4932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task is not used and defined anymore as we removed the git-init base image Dockerfile now, we don't need it. It got removed in tektoncd#4765 but not from the `Pipeline`. This also removes it from the `kustomization.yml` file. This should help fix the plumbing issue we have with re-deploying nightly payload (`Task`, `Pipeline`, …), as the `kustomization.yml` as is was invalid. Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
the
release-note-none
tekton-robot
requested review from
afrittoli,
imjasonh,
jerop,
lbernick and
mattmoor
tekton-robot
added
kind/misc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The task is not used and defined anymore as we removed the git-init
base image Dockerfile now, we don't need it. It got removed in #4765
but not from the
Pipeline.This also removes it from the
kustomization.ymlfile. This shouldhelp fix the plumbing issue we have with re-deploying nightly
payload (
Task,Pipeline, …), as thekustomization.ymlas is was invalid.Signed-off-by: Vincent Demeester [email protected]
/kind misc
/cc @imjasonh @mattmoor @abayer @afrittoli @lbernick @jerop
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes