Skip to content

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented May 27, 2022

Changes

Enables dependabot for pipelines.

See
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file
for more details.

Signed-off-by: Billy Lynch [email protected]

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • [n/a] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. labels May 27, 2022
@tekton-robot tekton-robot requested review from dlorenc and jerop May 27, 2022 18:16
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2022
@wlynch
Copy link
Member Author

wlynch commented May 27, 2022

cc @imjasonh @afrittoli

@wlynch
Copy link
Member Author

wlynch commented May 27, 2022

/cc @imjasonh @afrittoli

@vdemeester
Copy link
Member

@wlynch this is linked to tektoncd/plumbing#1028 right ?
One "tricky" thing about pipeline is that, we need to do "extra stuff" when we upgrade dependencies : (re)-generate code, …, maybe applying a temporary patch, … We might have to run our own "dependabot-like" way of upgrading dependencies instead of using dependabot direclty.

@wlynch
Copy link
Member Author

wlynch commented May 31, 2022

One "tricky" thing about pipeline is that, we need to do "extra stuff" when we upgrade dependencies : (re)-generate code, …, maybe applying a temporary patch, … We might have to run our own "dependabot-like" way of upgrading dependencies instead of using dependabot direclty.

Yeah, though this probably won't make that any harder.

I think worst case we'll get a few PRs that won't pass unit tests (probably for anything k8s.io related), which will be a signal for additional intervention. Even if we can only use this with 80% of deps, it seems worthwhile to enable it. If this ends up being too noisy we can roll it back.

@vdemeester
Copy link
Member

Yeah, though this probably won't make that any harder.

I think worst case we'll get a few PRs that won't pass unit tests (probably for anything k8s.io related), which will be a signal for additional intervention. Even if we can only use this with 80% of deps, it seems worthwhile to enable it. If this ends up being too noisy we can roll it back.

Fair enough 🙃

@vdemeester
Copy link
Member

@wlynch I am trying this with tektoncd/cli, as you convinced me this could work 🙃. The only trick to it is the release-note block that will be missing, but, might be ok-ish

@imjasonh
Copy link
Member

imjasonh commented Jun 2, 2022

/test pull-tekton-pipeline-go-coverage

@imjasonh
Copy link
Member

imjasonh commented Jun 2, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "daily"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put this to weekly ? I moved to weekly for hub just because with npm it was generating a lot of PR often.. but maybe we are fine here.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow
Let there be dragons 😓 🙃

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow
Let there be dragons 😓 🙃

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
@vdemeester
Copy link
Member

/retest

@wlynch
Copy link
Member Author

wlynch commented Jun 2, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@afrittoli
Copy link
Member

/test pull-pipeline-kind-k8s-v1-21-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants