[TEP-0076]Support Array Results substitution #4908

Yongxuanzhang · 2022-05-25T18:25:04Z

Changes

This is part of work in TEP-0076.
This commit provides the support to apply array results replacements.
Previous this commit we support emitting array results so users can
write array results to task level, but we cannot pass array results from
tasks within one pipeline. This commit adds the support for this.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Docs included if any changes are user facing
Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes

Support array results substitution as an alpha feature.

A task can specify a type to produce array result, such as:

  results:
    - name: array-results
       type: array
       description: The array results

And the task script can populate result in an array form with:

echo -n "[\"hello\",\"world\"]" | tee $(results.array-results.path)

and we can refer to the array results in param like:
  params:
    - name: foo
      value: "$(tasks.task1.results.array-results[*])"

This feature is part of the TEP-0076.

tekton-robot · 2022-05-25T18:28:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/when_types.go	100.0%	96.7%	-3.3
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.0%	94.5%	0.5
pkg/reconciler/taskrun/validate_resources.go	93.7%	94.0%	0.3

tekton-robot · 2022-05-25T18:44:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/when_types.go	100.0%	96.7%	-3.3
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.0%	94.5%	0.5
pkg/reconciler/taskrun/validate_resources.go	93.7%	94.0%	0.3

tekton-robot · 2022-05-25T18:54:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.0%	94.5%	0.5
pkg/reconciler/taskrun/validate_resources.go	93.7%	94.0%	0.3

tekton-robot · 2022-05-25T18:57:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.0%	95.6%	1.6
pkg/reconciler/taskrun/validate_resources.go	93.7%	94.0%	0.3

tekton-robot · 2022-05-25T20:04:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.0%	94.5%	0.5
pkg/reconciler/taskrun/validate_resources.go	93.7%	94.0%	0.3

tekton-robot · 2022-05-25T20:24:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.0%	94.5%	0.5
pkg/reconciler/taskrun/validate_resources.go	93.7%	94.0%	0.3

Yongxuanzhang · 2022-05-25T20:35:18Z

/assign @ywluogg

tekton-robot · 2022-05-25T20:35:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.0%	94.5%	0.5
pkg/reconciler/taskrun/validate_resources.go	93.7%	94.0%	0.3

tekton-robot · 2022-05-25T20:35:20Z

@Yongxuanzhang: GitHub didn't allow me to assign the following users: ywluogg.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ywluogg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2022-05-25T20:48:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.0%	94.5%	0.5
pkg/reconciler/taskrun/validate_resources.go	93.7%	94.0%	0.3

tekton-robot · 2022-05-25T21:03:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.0%	94.5%	0.5
pkg/reconciler/taskrun/validate_resources.go	93.7%	94.0%	0.3

Yongxuanzhang · 2022-05-25T21:56:10Z

/retest

ywluogg · 2022-05-25T22:54:31Z

/assign

dibyom

Couple of small things, otherwise LGTM!

pkg/apis/pipeline/v1beta1/result_types.go

docs/pipelines.md

tekton-robot · 2022-07-04T18:08:05Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.6%	96.0%	1.4
pkg/reconciler/taskrun/validate_resources.go	96.1%	96.2%	0.0

Yongxuanzhang · 2022-07-04T20:41:18Z

/retest

tekton-robot · 2022-07-04T21:14:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/apply.go	99.2%	99.2%	0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.6%	95.0%	0.4
pkg/reconciler/taskrun/validate_resources.go	96.1%	96.2%	0.0

ywluogg · 2022-07-05T14:54:21Z

Except for the existing open comments, other LGTM

ywluogg · 2022-07-05T14:54:27Z

/lgtm

tekton-robot · 2022-07-05T15:44:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/apply.go	99.2%	99.2%	0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.6%	95.0%	0.4
pkg/reconciler/taskrun/validate_resources.go	96.1%	96.2%	0.0

tekton-robot · 2022-07-05T16:07:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/apply.go	99.2%	99.2%	0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.6%	95.0%	0.4
pkg/reconciler/taskrun/validate_resources.go	96.1%	96.2%	0.0

tekton-robot · 2022-07-05T16:40:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/apply.go	99.2%	99.2%	0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.6%	95.0%	0.4
pkg/reconciler/taskrun/validate_resources.go	96.1%	96.2%	0.0

This is part of work in TEP-0076. This commit provides the support to apply array results replacements. Previous this commit we support emitting array results so users can write array results to task level, but we cannot pass array results from tasks within one pipeline. This commit adds the support for this.

tekton-robot · 2022-07-05T23:48:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/result_types.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/apply.go	99.2%	99.2%	0.0
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	94.6%	96.0%	1.3
pkg/reconciler/taskrun/validate_resources.go	96.1%	96.2%	0.0

Yongxuanzhang · 2022-07-05T23:49:10Z

/retest

ywluogg · 2022-07-06T17:56:25Z

/lgtm

dibyom · 2022-07-06T21:04:31Z

/approve

Thanks @Yongxuanzhang :D

tekton-robot · 2022-07-06T21:04:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, ywluogg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 25, 2022

tekton-robot requested review from dlorenc and imjasonh May 25, 2022 18:25

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2022

Yongxuanzhang force-pushed the results-array-substitution branch from aa9b79a to 4c7a14d Compare May 25, 2022 18:41

Yongxuanzhang force-pushed the results-array-substitution branch 2 times, most recently from 2056ea5 to c5c5108 Compare May 25, 2022 18:51

Yongxuanzhang force-pushed the results-array-substitution branch from c5c5108 to 919b43c Compare May 25, 2022 20:02

Yongxuanzhang force-pushed the results-array-substitution branch from 919b43c to 0fe4059 Compare May 25, 2022 20:20

Yongxuanzhang force-pushed the results-array-substitution branch from 0fe4059 to c687908 Compare May 25, 2022 20:32

Yongxuanzhang marked this pull request as ready for review May 25, 2022 20:35

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2022

Yongxuanzhang force-pushed the results-array-substitution branch from c687908 to d656f4f Compare May 25, 2022 20:45

Yongxuanzhang force-pushed the results-array-substitution branch from d656f4f to 165258b Compare May 25, 2022 20:59

tekton-robot assigned ywluogg May 25, 2022

Yongxuanzhang force-pushed the results-array-substitution branch from 165258b to 43c8a35 Compare May 26, 2022 00:54

dibyom reviewed Jul 1, 2022

View reviewed changes

pkg/apis/pipeline/v1beta1/result_types.go Outdated Show resolved Hide resolved

docs/pipelines.md Outdated Show resolved Hide resolved

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2022

Yongxuanzhang force-pushed the results-array-substitution branch from 650f3c3 to 1b3a83f Compare July 4, 2022 18:02

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2022

Yongxuanzhang force-pushed the results-array-substitution branch from f89c355 to 0bedc86 Compare July 5, 2022 15:40

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2022

Yongxuanzhang force-pushed the results-array-substitution branch from 0bedc86 to 9f96b36 Compare July 5, 2022 16:03

Yongxuanzhang force-pushed the results-array-substitution branch from 9f96b36 to 3faf6ee Compare July 5, 2022 16:36

Yongxuanzhang force-pushed the results-array-substitution branch from 3faf6ee to 4cf2cc9 Compare July 5, 2022 23:40

Yongxuanzhang mentioned this pull request Jul 5, 2022

[TEP-0075] Support Object Results substitution #5083

Merged

5 tasks

Yongxuanzhang requested a review from dibyom July 6, 2022 00:30

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2022

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022

tekton-robot merged commit 9b4bba2 into tektoncd:main Jul 6, 2022

Yongxuanzhang mentioned this pull request Sep 27, 2022

Mark tep75&76 implemented tektoncd/community#833

Merged

[TEP-0076]Support Array Results substitution #4908

[TEP-0076]Support Array Results substitution #4908

Uh oh!

Conversation

Yongxuanzhang commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

Yongxuanzhang commented May 25, 2022

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

tekton-robot commented May 25, 2022

Uh oh!

Yongxuanzhang commented May 25, 2022

Uh oh!

ywluogg commented May 25, 2022

Uh oh!

dibyom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Jul 4, 2022

Uh oh!

Yongxuanzhang commented Jul 4, 2022

Uh oh!

tekton-robot commented Jul 4, 2022

Uh oh!

ywluogg commented Jul 5, 2022

Uh oh!

ywluogg commented Jul 5, 2022

Uh oh!

tekton-robot commented Jul 5, 2022

Uh oh!

tekton-robot commented Jul 5, 2022

Uh oh!

tekton-robot commented Jul 5, 2022

Uh oh!

tekton-robot commented Jul 5, 2022

Uh oh!

Yongxuanzhang commented Jul 5, 2022

Uh oh!

ywluogg commented Jul 6, 2022

Uh oh!

dibyom commented Jul 6, 2022

Uh oh!

tekton-robot commented Jul 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Yongxuanzhang commented May 25, 2022 •

edited

Loading