TEP-0059: Remove scope-when-expressions-to-task feature flag
#4715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
tekton-robot
removed
the
do-not-merge/work-in-progress
In [TEP-0007: Conditions Beta][tep-0007], we introduced `when` expressions to guard execution of `Tasks` in `Pipelines`. To align with `Conditions`, we set scope of `when` expressions to the guarded `Task` and its dependent `Tasks`. In [TEP-0059: Skipping Strategies][tep-0059], we proposed changing the scope of `when` expressions to the guarded `Task` only. This was implemented in #4085. We provided a feature flag, `scope-when-expressions-to-task`, to support migration. It defaulted to `false` for 9 months per our [Beta API compatibility policy][policy], meaning that we continued to guard the `Task` and its dependent `Tasks`. Then in #4580, we flipped the flag to `true` to guard the `Task` only by default. In this change, we remove the `scope-when-expressions-to-task` flag and complete the migration. Closes #4461. [tep-0007]: https://github.com/tektoncd/community/blob/main/teps/0007-conditions-beta.md [tep-0059]: https://github.com/tektoncd/community/blob/main/teps/0059-skipping-strategies.md [policy]: https://github.com/tektoncd/pipeline/blob/main/api_compatibility_policy.md
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
l-qing
added a commit
to l-qing/tekton-operator
that referenced
this pull request
Jun 26, 2024
This feature flag has been completely removed in v0.35. Ref: tektoncd/pipeline#4715
l-qing
added a commit
to l-qing/tekton-operator
that referenced
this pull request
Jun 26, 2024
This feature flag has been completely removed in v0.35. Ref: tektoncd/pipeline#4715
4 tasks
l-qing
added a commit
to l-qing/pipeline
that referenced
this pull request
Jun 26, 2024
This feature flag has been completely removed in v0.35. Ref: tektoncd#4715
8 tasks
l-qing
added a commit
to l-qing/pipeline
that referenced
this pull request
Jun 27, 2024
This feature flag has been completely removed in v0.35. Ref: tektoncd#4715
l-qing
added a commit
to l-qing/tekton-operator
that referenced
this pull request
Jul 3, 2024
This feature flag has been completely removed in v0.35. Ref: tektoncd/pipeline#4715
tekton-robot
pushed a commit
to tektoncd/operator
that referenced
this pull request
Jul 3, 2024
This feature flag has been completely removed in v0.35. Ref: tektoncd/pipeline#4715
tekton-robot
pushed a commit
that referenced
this pull request
Jul 3, 2024
This feature flag has been completely removed in v0.35. Ref: #4715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In TEP-0007: Conditions Beta, we introduced
whenexpressions to guard execution ofTasksinPipelines. To align withConditions, we set scope ofwhenexpressions to the guardedTaskand its dependentTasks.In TEP-0059: Skipping Strategies, we proposed changing the scope of
whenexpressions to the guardedTaskonly. This was implemented in #4085. We provided a feature flag,scope-when-expressions-to-task, to support migration. It defaulted tofalsefor 9 months per our Beta API compatibility policy, meaning that we continued to guard theTaskand its dependentTasks. Then in #4580, we flipped the flag totrueto guard theTaskonly by default.In this change, we remove the
scope-when-expressions-to-taskflag and complete the migration.Closes #4461.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes