Skip *heavy* validation on deletion 🙃

[vdemeester]

Changes

When deleting an object, we don't need to pursue all the validation
that we do at creation. It reduces the work to be done as part of the
validation and allows invalid version of the resource (from previous
versions for example) to be deleted safely.

Signed-off-by: Vincent Demeester [email protected]

The main reasoning for this change is to not face issues to reduce the situation where an upgrade makes object not deletable (because of newly invalid field). One example that happen in triggers is upgrading from 0.10.x to 0.12.x make EventListener not deletable at all.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Skip *heavy* validation on deletion in the webhook

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_validation.go	90.0%	83.3%	-6.7
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.8%	97.1%	-0.7
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	95.5%	91.7%	-3.8
pkg/apis/pipeline/v1alpha1/run_validation.go	87.5%	83.3%	-4.2
pkg/apis/pipeline/v1alpha1/task_validation.go	83.7%	82.8%	-0.9
pkg/apis/pipeline/v1alpha1/taskrun_validation.go	89.8%	88.5%	-1.3
pkg/apis/pipeline/v1beta1/pipeline_validation.go	100.0%	99.6%	-0.4
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	100.0%	97.1%	-2.9
pkg/apis/pipeline/v1beta1/task_validation.go	96.3%	95.2%	-1.2
pkg/apis/pipeline/v1beta1/taskrun_validation.go	100.0%	97.6%	-2.4
pkg/apis/resource/v1alpha1/pipelineresource_validation.go	90.2%	88.9%	-1.3

[ghost]

The main reasoning for this change is to not face issues to reduce the situation where an upgrade makes object not deletable (because of newly invalid field). One example that happen in triggers is upgrading from 0.10.x to 0.12.x make EventListener not deletable at all.

Nice. This has also hit me when I'm developing a new feature. Going back to the current HEAD of pipelines/main means that the taskruns with the new feature syntax cannot be deleted.

[ghost]

Cool. I don't think I've seen IsInDelete and related funcs from knative before.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[imjasonh]

Nice find!

/lgtm

[vdemeester]

/hold
Let me add some simple unit tests 🙃

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_validation.go	90.0%	83.3%	-6.7
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.8%	97.1%	-0.7
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	95.5%	91.7%	-3.8
pkg/apis/pipeline/v1alpha1/run_validation.go	87.5%	83.3%	-4.2
pkg/apis/pipeline/v1alpha1/task_validation.go	83.7%	82.8%	-0.9
pkg/apis/pipeline/v1alpha1/taskrun_validation.go	89.8%	88.5%	-1.3
pkg/apis/pipeline/v1beta1/task_validation.go	96.3%	97.0%	0.7
pkg/apis/resource/v1alpha1/pipelineresource_validation.go	90.2%	88.9%	-1.3

[vdemeester]

/hold cancel

[pritidesai]

this is interesting, context tells you whether a resource is being deleted 😲

/lgtm

[nikhil-thomas]

this is interesting, context tells you whether a resource is being deleted 😲

/lgtm

Thanks for pointing it out. 🧑‍💻 👍
very useful in tektoncd/operator work. 🙂

[pritidesai]

would this work? 🤔

/test pull-tekton-pipeline-alpha-integration-tests

[vdemeester]

/retest

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/condition_validation.go	90.0%	83.3%	-6.7
pkg/apis/pipeline/v1alpha1/pipeline_validation.go	97.8%	97.1%	-0.7
pkg/apis/pipeline/v1alpha1/pipelinerun_validation.go	95.5%	91.7%	-3.8
pkg/apis/pipeline/v1alpha1/run_validation.go	95.8%	92.3%	-3.5
pkg/apis/pipeline/v1alpha1/task_validation.go	83.7%	82.8%	-0.9
pkg/apis/pipeline/v1alpha1/taskrun_validation.go	89.8%	88.5%	-1.3
pkg/apis/pipeline/v1beta1/task_validation.go	96.3%	97.0%	0.7
pkg/apis/resource/v1alpha1/pipelineresource_validation.go	90.2%	88.9%	-1.3

[vdemeester]

/retest
Somehow the jobs got killed..

[pritidesai]

/lgtm

[vdemeester]

/retest