TaskRun, and PipelineRun auto-conversion from v1alpha1 to v1alpha2 🎋 #2025
Conversation
tekton-robot
added
the
do-not-merge/hold
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XXL
|
/cc @bobcatfish |
|
The following is the coverage report on pkg/.
|
vdemeester
force-pushed
the
v1alpha2-auto-conversion-run
branch
from
7c083dd to
5c387d0
Compare
|
The following is the coverage report on pkg/.
|
vdemeester
force-pushed
the
v1alpha2-auto-conversion-run
branch
from
5c387d0 to
843ac21
Compare
|
The following is the coverage report on pkg/.
|
|
|
||
| t := &v1alpha1.TaskSpec{ | ||
| Steps: []v1alpha1.Step{rcc.Condition.Spec.Check}, | ||
| TaskSpec: v1alpha2.TaskSpec{ |
There was a problem hiding this comment.
nit: in a bunch of other places we're not nesting this on a newline. We're doing t := &v1alpha1.TaskSpec{TaskSpec: v1alpha2.TaskSpec{)
I really don't mind either way which format is used but figure we should probably be consistent.
There was a problem hiding this comment.
Usually I am doing &v1alpha1.TaskSpec{TaskSpec: v1alpha2.TaskSpec{ if TaskSpec is the only field in the struct, otherwise I aligne them 😅
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vdemeester
force-pushed
the
v1alpha2-auto-conversion-run
branch
from
843ac21 to
6a3198b
Compare
|
The following is the coverage report on pkg/.
|
vdemeester
force-pushed
the
v1alpha2-auto-conversion-run
branch
from
6a3198b to
daf5ded
Compare
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
The following is the coverage report on pkg/.
|
This adds auto-conversion methods and tests for TaskRun types in v1alpha1 and v1alpha2. Signed-off-by: Vincent Demeester <[email protected]>
This adds auto-conversion methods and tests for PipelineRun types in v1alpha1 and v1alpha2. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
v1alpha2-auto-conversion-run
branch
from
daf5ded to
3e65f90
Compare
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
/test pull-tekton-pipeline-build-tests |
4 participants
Changes
This adds
Depends on #2002
/hold
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.