Cleanup: uplevel our technical hygiene by enabling additional Golang linters

[bendory]

Feature request

golangci-lint which we have configured supports additional helpful linters that we are not using.
This FR suggests that we uplevel our technical hygiene by enabling more linters and cleaning up
the issues they identify.

Note: I'd like to see the same linter suite applied across all tektoncd repos.

Documentation: https://golangci-lint.run/usage/linters
See also: http://goo.gle/go-style

Linters that I would like to see enabled:

• bodyclose - Enabled additional linters. #5924
• containedctx - Hygiene: enable containedctx linter. #6261
• decorder - Enabled additional linters. #5924
• depguard
• dogsled - Hygiene: enable goconst, dogsled linters. #6262
• dupl
• dupword - Enabled dupword and usestdlibvars linters. #5918
  • Cleanup: delete duplicate words. #5923
• errcheck
• errchkjson - Hygiene: enable linters for error conventions. #6264
• errname - Hygiene: enable linters for error conventions. #6264
• errorlint - Hygiene: enable errorlint. #6340
• exhaustive -- Hygiene: enable exhaustive linter. #6484
• funlen
• gocognit
• goconst - Hygiene: enable goconst, dogsled linters. #6262
• gocritic
• gofmt
• goimports
• gomodguard
• gosec
• gosimple -- Enabled gosimple linter. #5904
• govet
• ineffassign -- Hygiene: enable ineffassign linter. 🧹🧹🧹 #6259
• ireturn
• misspell
• nosnakecase (deprecated)
• revive
• staticcheck
• thelper -- Enabled thelper linter. #5927
• tparallel
• typecheck -- Enabled additional linters. #5924
• unconvert
• unparam
• unused -- Replaced deadcode linter with unused linter. #5881
• usestdlibvars -- Enabled dupword and usestdlibvars linters. #5918
• varnamelen
• whitespace -- Enabled the whitespace linter. #5889
• wrapcheck

[bendory]

I would assign this issue to me, but I don't seem to have the authority to do so. 🙃

[bendory]

#5871 Added govet to our Golang linter suite
#5881 Replaced deprecated deadcode linter with unused linter
#5889 Enabled the whitespace linter.

[vdemeester]

/assign @bendory
(btw, if you comment /assign, it should automatically assign the issue to you 😉 )

[vdemeester]

(ah lol, @jerop manually assigned you already 😂 )

[bendory]

See also: tektoncd/community#908 Add Go style guide to community standards (thanks @lbernick)