-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
Expected Behavior
As documented here for labels (and it used to be the same for annotations), labels and annotations set on the Task should be propagated to the underlying Pod when run.
Actual Behavior
As of today, annotations and labels set on the Task are lost in translation and only labels and annotations from the TaskRun are passed to the generated Pod.
Steps to Reproduce the Problem
- Create a
Taskwith an annotation and a label - Create a
TaskRunthat reference it - Look at the
Podassociated with theTaskRun, it will not have the annotation nor the label set on theTask
Additional Info
- Kubernetes version:
Any version
- Tekton Pipeline version:
Current main and most likely since this PR, meaning since 0.25 or 0.26 ? 🤔
The main reason for this bug is that, because we are using the .Status.Spec to re-construct the Task definition and we are not storing annotation and labels in there, we are not using them when creating the Pod.
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.