Skip to content

Conversation

@briangleeson
Copy link
Contributor

@briangleeson briangleeson commented Oct 10, 2025

Changes

Issue: #3492

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2025
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
@briangleeson briangleeson added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Oct 10, 2025
@briangleeson
Copy link
Contributor Author

briangleeson commented Oct 10, 2025

⚠️ BLOCKER: WebSockets are not working properly for me locally, but I suspect it's some issue within kind/podman/WSL/WIndows that is causing them to break

Using kubectl proxy instead of port forwarding as a workaround works well. Haven't figured out the underlyiung websocket issue though

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2025
@briangleeson
Copy link
Contributor Author

briangleeson commented Oct 13, 2025

⚠️ Issue in tests: waitForNextUpdate has been removed from testing-library/react. There isn't a direct replacement, and so the two places in the tests that were using it are not fully working with my attempted replacements in src/api/utils.test.js

Solution found and added to tests

@briangleeson
Copy link
Contributor Author

briangleeson commented Oct 15, 2025

⚠️ PR checks issue: There's an npm auth failure in the GH Actions workflow for this PR

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2025
@briangleeson
Copy link
Contributor Author

/retest

@briangleeson briangleeson force-pushed the react18 branch 2 times, most recently from bf482b2 to 3000c78 Compare October 28, 2025 16:54
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2025
@briangleeson
Copy link
Contributor Author

briangleeson commented Oct 28, 2025

⚠️ PR checks issue: There's an npm auth failure in the GH Actions workflow for this PR

Fixed by latest commit, and rebased with latest

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2025
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2025
@AlanGreene

This comment was marked as resolved.

@briangleeson

This comment was marked as resolved.

@AlanGreene

This comment was marked as resolved.

@briangleeson briangleeson marked this pull request as ready for review October 30, 2025 12:31
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log requests are duplicated. Each time the step container logs are loaded, 2 requests are made. Previously there was just 1 request.

@AlanGreene AlanGreene removed the request for review from skaegi October 30, 2025 21:17
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2025
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2025
@briangleeson
Copy link
Contributor Author

Log requests are duplicated. Each time the step container logs are loaded, 2 requests are made. Previously there was just 1 request.

We determined that this occurs with usage of <StrictMode> wrapper in the app for development mode. It highlights a potential issue of duplicate log fetching requests, due to the lack of an abort handler in the unmount of Log.jsx. But it doesnt have a material impact in local dev env other than duplicate network requests in dev tools, and does not affect production mode. So we are choosing to ignore this for now, as attempting to fix it by adding an AbortController was tricky since Logs. jsx is still a React component using componentDidMount rather than a functional component using useEffect.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@AlanGreene
Copy link
Member

Thanks @briangleeson. This one wasn't straightforward, so the effort is much appreciated.
/lgtm
/meow

@tekton-robot
Copy link
Contributor

@AlanGreene: cat image

In response to this:

Thanks @briangleeson. This one wasn't straightforward, so the effort is much appreciated.
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@tekton-robot tekton-robot merged commit 85602fd into tektoncd:main Nov 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants