- 
                Notifications
    You must be signed in to change notification settings 
- Fork 281
add configmap which can contain dashboard info and RBAC to access this configmap #2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hi @cpanato. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks or the PR @cpanato, it'll be good to be consistent with the other projects. I've added a couple of comments, let me know if you have any questions.
/ok-to-test
…s configmap Signed-off-by: Carlos Panato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @cpanato
/lgtm
/meow
| In response to this: 
 Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. | 
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 

Changes
As of now, we fetch the version of pipelines through labels present on the
deployments which are read by tools such as
tkn cliand display theversion. This version may not be displayed to users if they don't have
permission to view the deployment.
In this commit, we are adding
irrespective of whether user is has permission to view other objects in
that namespace or not.
Similar that were done in tektoncd/pipeline#3971 and tektoncd/triggers#1114
This is covered as part of TEP-0041
Fixes: #2089
/kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.