Skip to content

Conversation

@cpanato
Copy link
Contributor

@cpanato cpanato commented Jun 15, 2021

Changes

As of now, we fetch the version of pipelines through labels present on the
deployments which are read by tools such as tkn cli and display the
version. This version may not be displayed to users if they don't have
permission to view the deployment.

In this commit, we are adding

  • A ConfigMap which contains version information.
  • RBAC which will give appropriate permissions to view the ConfigMap
    irrespective of whether user is has permission to view other objects in
    that namespace or not.

Similar that were done in tektoncd/pipeline#3971 and tektoncd/triggers#1114

This is covered as part of TEP-0041

Fixes: #2089

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2021
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 15, 2021
@tekton-robot
Copy link
Contributor

Hi @cpanato. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato changed the title add ConfigMap which can contain dashboard info and RBAC to access this configmap add configmap which can contain dashboard info and RBAC to access this configmap Jun 15, 2021
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks or the PR @cpanato, it'll be good to be consistent with the other projects. I've added a couple of comments, let me know if you have any questions.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2021
Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @cpanato

/lgtm
/meow

@tekton-robot
Copy link
Contributor

@AlanGreene: cat image

In response to this:

Looks great, thanks @cpanato

/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@tekton-robot tekton-robot merged commit 05e283b into tektoncd:main Jun 16, 2021
@cpanato cpanato deleted the GH-2089 branch June 16, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a configmap which contains dashboard version

3 participants