[Satellite region]: add IAM permissions for supporting feature service running in satellite region #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e running in satellite region
yan-lgtm
reviewed
Oct 5, 2022
There was a problem hiding this comment.
bunch of nits as I usually get the same comments from @scottames.
| } | ||
|
|
||
| # CROSS ACCOUNT SATELLITE SERVING | ||
| resource "aws_iam_policy" "emr_cross_account_satellite_region_policy" { |
There was a problem hiding this comment.
nit: rename this to emr_cross_account_satellite_region since this is aws_iam_policy already
| }) | ||
| tags = local.tags | ||
| } | ||
| resource "aws_iam_role_policy_attachment" "emr_cross_account_satellite_region_policy_attachment" { |
There was a problem hiding this comment.
same here rename to emr_cross_account_satellite_region since it's already policy_attachment by resource
| role = local.spark_role_name | ||
| } | ||
|
|
||
| resource "aws_iam_policy" "satellite_region_policy" { |
| }) | ||
| tags = local.tags | ||
| } | ||
| resource "aws_iam_role_policy_attachment" "satellite_region_policy_attachment" { |
|
@zhoujoetan any progress here? |
|
I'll get on it. It's been way too long lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add IAM permissions for supporting feature service running in satellite region
Why
Tecton requires extra IAM permissions to set up feature serving stack running in satellite region