Skip to content

fix: Add ARN output for emr-master-role. #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

fix: Add ARN output for emr-master-role. #248

merged 1 commit into from
Aug 18, 2025

Conversation

eshiferax
Copy link
Contributor

@eshiferax eshiferax commented Aug 18, 2025 •
edited
Loading

The EMR wrapper modules (controlplane_rift_with_emr, emr) currently reference a non-existent output when writing to the shared bucket/location, which causes this issue in TF plan.:

╷
│ Error: Unsupported attribute
│ 
│   on .terraform/modules/tecton/modules/controlplane_rift_with_emr/infrastructure.tf line 123, in module "tecton_outputs":
│  123:     emr_master_role_arn                 = module.tecton.emr_master_role_arn
│     ├────────────────
│     │ module.tecton is a object
│ 
│ This object does not have an attribute named "emr_master_role_arn".

Fixing by adding the expected output (previously only the name was there, adding ARN too).

Tested by updating an internal cluster to reference this branch -- no longer see the error in plan.

@eshiferax Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eshiferax eshiferax marked this pull request as ready for review August 18, 2025 14:38
@eshiferax eshiferax requested a review from a team August 18, 2025 14:39
@eshiferax eshiferax merged commit 90843bb into master Aug 18, 2025
1 of 3 checks passed
@eshiferax eshiferax deleted the fix-emr-output branch August 18, 2025 15:12
@github-actions github-actions bot mentioned this pull request Aug 18, 2025
Merged
eshiferax pushed a commit that referenced this pull request Aug 18, 2025
@github-actions
chore(master): release 1.8.1 (#249)
925082a 
🤖 I have created a release *beep* *boop*
---


##
[1.8.1](v1.8.0...v1.8.1)
(2025-08-18)


### Bug Fixes

* Add ARN output for emr-master-role.
([#248](#248))
([90843bb](90843bb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TihoElek TihoElek TihoElek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eshiferax @TihoElek