feat: Set default tecton_outputs location to presigned url. #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titilambert
reviewed
Jun 16, 2025
titilambert
approved these changes
Jun 16, 2025
eshiferax
pushed a commit
that referenced
this pull request
Jun 16, 2025
🤖 I have created a release *beep* *boop* --- ## [1.7.0](v1.6.0...v1.7.0) (2025-06-16) ### Features * Set default tecton_outputs location to presigned url. ([#224](#224)) ([496cadc](496cadc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typefor output location config totecton_hosted_presigned, and update all READMEs / sample snippets for module invocations to show that the URL is an expected input. The default behavior will be to write outputs to an s3 location with URL provided by Tecton, instead of creating a new bucket or using the offline-store (although those remain as options).location_configvariable name tooutputs_location_configfor clarity.vm_workload_subnet_idsvariable intecton_outputsmodule (stringinstead oflist(string)).Testing
Tested with invocation of
dataplane_riftmodule against this branch using?ref=tecton-outputs-update, with a presigned URL input. Terraform Apply worked in general + outputs written as expected.