feat: Add option to extend allowed buckets (for read) for Rift Compute role #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For S3 tecton data sources (i.e.
FileConfig
BatchSource
) in the same account as the dataplane, users currently need to manually edit theirtecton-rift-compute
role in order to give the jobs access to read those buckets(if the source bucket is in a different account, they can get access with an s3 bucket policy + existing policy statement that already allows reads for buckets in separate accounts)
We should provide an option for this (additional read permissions for
tecton-rift-compute
) to be added via terraform to avoid drift / risk of removing their changes if they need to pull in updates or re-apply.Adding new variable
additional_s3_read_access_buckets
(list of bucket names) here to support this.Testing
additional_s3_read_access_buckets
== [tst-tecton-access
] Resulted in: