feat: Add options for disabling direct cross-account bucket policy and limiting cross-account assumerole #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two options to
rift_compute
module:controlplane_access_only
-- Whentrue
, this removes legacy153453085158
account from trust policy for cross-account role. This works for all newer accounts that only rely on access from roles in the control-plane account directly.include_crossaccount_bucket_access
-- Whentrue
, does not add bucket policy to offline-store bucket for direct cross-account access. This is OK for dataplane Rift, where all access to the offline-store will come through the assumed role in dataplane. ReferenceSetting defaults for both of these appropriately in
dataplane_rift
anddataplane_rift_with_emr
module. Control plane rift/existing direct users ofdeployment
module won't see a change, this only affects the 'new'modules/
users and will be default going forward.Tested with internal state, results in this type of change: