Skip to content

Conversation

zack13532
Copy link
Collaborator

@zack13532 zack13532 commented Dec 1, 2024

Changes all usages of parallelStream to stream in the client as it uses the common ForkJoinPool which probably hurts more than it helps.

fixes gh-49

@zack13532
Copy link
Collaborator Author

zack13532 commented Dec 1, 2024

@zack13532 zack13532 force-pushed the 12-01-remove_usage_of_parallelstream_in_favor_of_stream branch from b2a6a42 to 8db4175 Compare December 1, 2024 22:36
@zack13532 zack13532 marked this pull request as ready for review December 1, 2024 22:38
@zack13532 zack13532 requested a review from yan-lgtm December 1, 2024 22:38
@zack13532 zack13532 changed the title Remove usage of parallelStream in favor of stream Remove usage of parallelStream in favor of stream and bump version Dec 1, 2024
@zack13532 zack13532 force-pushed the 12-01-remove_usage_of_parallelstream_in_favor_of_stream branch from 8db4175 to bc06397 Compare December 1, 2024 23:06
@zack13532 zack13532 changed the base branch from 11-25-update_readme_for_0.9.2 to graphite-base/91 December 1, 2024 23:07
@zack13532 zack13532 force-pushed the 12-01-remove_usage_of_parallelstream_in_favor_of_stream branch from bc06397 to bf67d39 Compare December 1, 2024 23:07
@zack13532 zack13532 changed the base branch from graphite-base/91 to main December 1, 2024 23:07
@zack13532 zack13532 force-pushed the 12-01-remove_usage_of_parallelstream_in_favor_of_stream branch 2 times, most recently from 5d09964 to bcfe62e Compare December 2, 2024 04:10
@zack13532 zack13532 force-pushed the 12-01-remove_usage_of_parallelstream_in_favor_of_stream branch from bcfe62e to 30bf7c0 Compare December 2, 2024 05:00
@zack13532 zack13532 changed the title Remove usage of parallelStream in favor of stream and bump version Remove usage of parallelStream in favor of stream Dec 2, 2024
@zack13532 zack13532 mentioned this pull request Dec 2, 2024
@emmap321
Copy link

emmap321 commented Dec 2, 2024

Good find! Agree that we should fix this and ask them o try again. I found an old thread on this and pooja mentioned that it doesn't have any performance benefits. @poojabhat0 do you recall the reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove usage of parallelStream in the client

3 participants