-
Notifications
You must be signed in to change notification settings - Fork 1
Remove usage of parallelStream in favor of stream #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zack13532
wants to merge
1
commit into
main
Choose a base branch
from
12-01-remove_usage_of_parallelstream_in_favor_of_stream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove usage of parallelStream in favor of stream #91
zack13532
wants to merge
1
commit into
main
from
12-01-remove_usage_of_parallelstream_in_favor_of_stream
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
b2a6a42
to
8db4175
Compare
yan-lgtm
approved these changes
Dec 1, 2024
8db4175
to
bc06397
Compare
bc06397
to
bf67d39
Compare
5d09964
to
bcfe62e
Compare
This was referenced Dec 2, 2024
bcfe62e
to
30bf7c0
Compare
Good find! Agree that we should fix this and ask them o try again. I found an old thread on this and pooja mentioned that it doesn't have any performance benefits. @poojabhat0 do you recall the reason? |
emmap321
approved these changes
Dec 2, 2024
This was referenced Dec 3, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all usages of parallelStream to stream in the client as it uses the common ForkJoinPool which probably hurts more than it helps.
fixes gh-49