Set maxRequests for OkHttp dispatcher to maxParallelRequests #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zack13532
changed the title
emmap321
approved these changes
Nov 25, 2024
Merge activity
|
zack13532
deleted the
11-22-set_maxrequests_for_okhttp_dispatcher_to_the_same_value_as_maxparallelrequests
branch
zack13532
added a commit
that referenced
this pull request
Nov 27, 2024
Added usage examples to the readme and bump the version in preparation to release a [fix](#88) for setting max requests. Released a snapshot for 0.9.2-SNAPSHOT and successfully tested it with the [demo repo](https://github.com/tecton-ai/tecton-http-client-demo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively the same as maxRequestsPerHost, since the host for an instantiated TectonClient is always the same. Fixes a bug where the user-specified maxParallelRequests is greater than the default of 64 maxRequests, and so doesn't take effect.